From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Gross Subject: Re: [PATCH 3 of 3] libxl: do not write/maintain "pool_name" in XenStore Date: Tue, 24 Jan 2012 09:07:58 +0100 Message-ID: <4F1E66DE.8030800@ts.fujitsu.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Campbell Cc: ian.jackson@citrix.com, xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 01/23/2012 03:43 PM, Ian Campbell wrote: > # HG changeset patch > # User Ian Campbell > # Date 1327329565 0 > # Node ID d8efdb16b1ef06013061da1f47c2dbce4b042992 > # Parent 10f5656caaaa2bdfd6a7ae9aada903da8bddcbb6 > libxl: do not write/maintain "pool_name" in XenStore > > Nothing that I can find ever reads this key. > > Signed-off-by: Ian Campbell Acked-by: juergen.gross@ts.fujitsu.com > diff -r 10f5656caaaa -r d8efdb16b1ef tools/libxl/libxl.c > --- a/tools/libxl/libxl.c Mon Jan 23 14:35:47 2012 +0000 > +++ b/tools/libxl/libxl.c Mon Jan 23 14:39:25 2012 +0000 > @@ -3434,16 +3434,6 @@ int libxl_cpupool_movedomain(libxl_ctx * > { > GC_INIT(ctx); > int rc; > - char *dom_path; > - char *vm_path; > - char *poolname; > - xs_transaction_t t; > - > - dom_path = libxl__xs_get_dompath(gc, domid); > - if (!dom_path) { > - GC_FREE; > - return ERROR_FAIL; > - } > > rc = xc_cpupool_movedomain(ctx->xch, poolid, domid); > if (rc) { > @@ -3453,21 +3443,6 @@ int libxl_cpupool_movedomain(libxl_ctx * > return ERROR_FAIL; > } > > - for (;;) { > - t = xs_transaction_start(ctx->xsh); > - > - poolname = libxl__cpupoolid_to_name(gc, poolid); > - vm_path = libxl__xs_read(gc, XBT_NULL, libxl__sprintf(gc, "%s/vm", dom_path)); > - if (!vm_path) > - break; > - > - libxl__xs_write(gc, t, libxl__sprintf(gc, "%s/pool_name", vm_path), > - "%s", poolname); > - > - if (xs_transaction_end(ctx->xsh, t, 0) || (errno != EAGAIN)) > - break; > - } > - > GC_FREE; > return 0; > } > diff -r 10f5656caaaa -r d8efdb16b1ef tools/libxl/libxl_create.c > --- a/tools/libxl/libxl_create.c Mon Jan 23 14:35:47 2012 +0000 > +++ b/tools/libxl/libxl_create.c Mon Jan 23 14:39:25 2012 +0000 > @@ -438,9 +438,6 @@ retry_transaction: > > xs_write(ctx->xsh, t, libxl__sprintf(gc, "%s/uuid", vm_path), uuid_string, strlen(uuid_string)); > xs_write(ctx->xsh, t, libxl__sprintf(gc, "%s/name", vm_path), info->name, strlen(info->name)); > - if (info->poolid != -1) > - libxl__xs_write(gc, t, libxl__sprintf(gc, "%s/pool_name", vm_path), > - "%s", libxl__cpupoolid_to_name(gc, info->poolid)); > > libxl__xs_writev(gc, t, dom_path, info->xsdata); > libxl__xs_writev(gc, t, libxl__sprintf(gc, "%s/platform", dom_path), info->platformdata); > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel > > -- Juergen Gross Principal Developer Operating Systems PDG ES&S SWE OS6 Telephone: +49 (0) 89 3222 2967 Fujitsu Technology Solutions e-mail: juergen.gross@ts.fujitsu.com Domagkstr. 28 Internet: ts.fujitsu.com D-80807 Muenchen Company details: ts.fujitsu.com/imprint.html