diff for duplicates of <4F1E8E31.1070507@bfs.de> diff --git a/a/1.txt b/N1/1.txt index 01379f4..55e177a 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -15,26 +15,26 @@ Am 24.01.2012 09:40, schrieb Dan Carpenter: > read_bytes = snprintf(&se_dev->se_dev_alias[0], SE_DEV_ALIAS_LEN, > "%s", page); -Would it help to check page=NULL or *page=0 at start ? +Would it help to check page==NULL or *page==0 at start ? Now you have se_dev->su_dev_flags initialised. re, wh -> + if (read_bytes = 0) +> + if (read_bytes == 0) > + return -EINVAL; > -> if (se_dev->se_dev_alias[read_bytes - 1] = '\n') +> if (se_dev->se_dev_alias[read_bytes - 1] == '\n') > se_dev->se_dev_alias[read_bytes - 1] = '\0'; > @@ -1756,6 +1758,8 @@ static ssize_t target_core_store_dev_udev_path( > se_dev->su_dev_flags |= SDF_USING_UDEV_PATH; > read_bytes = snprintf(&se_dev->se_dev_udev_path[0], SE_UDEV_PATH_LEN, > "%s", page); -> + if (read_bytes = 0) +> + if (read_bytes == 0) > + return -EINVAL; > -> if (se_dev->se_dev_udev_path[read_bytes - 1] = '\n') +> if (se_dev->se_dev_udev_path[read_bytes - 1] == '\n') > se_dev->se_dev_udev_path[read_bytes - 1] = '\0'; > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in diff --git a/a/content_digest b/N1/content_digest index 60c74b2..0237783 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\020120124084036.GB29097@elgon.mountain\0" "From\0walter harms <wharms@bfs.de>\0" "Subject\0Re: [patch] target: handle empty string writes in sysfs\0" - "Date\0Tue, 24 Jan 2012 10:55:45 +0000\0" + "Date\0Tue, 24 Jan 2012 11:55:45 +0100\0" "To\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Cc\0Nicholas A. Bellinger <nab@linux-iscsi.org>" linux-scsi@vger.kernel.org @@ -26,26 +26,26 @@ "> \tread_bytes = snprintf(&se_dev->se_dev_alias[0], SE_DEV_ALIAS_LEN,\n" "> \t\t\t\"%s\", page);\n" "\n" - "Would it help to check page=NULL or *page=0 at start ?\n" + "Would it help to check page==NULL or *page==0 at start ?\n" "Now you have se_dev->su_dev_flags initialised.\n" "\n" "re,\n" " wh\n" "\n" "\n" - "> +\tif (read_bytes = 0)\n" + "> +\tif (read_bytes == 0)\n" "> +\t\treturn -EINVAL;\n" "> \n" - "> \tif (se_dev->se_dev_alias[read_bytes - 1] = '\\n')\n" + "> \tif (se_dev->se_dev_alias[read_bytes - 1] == '\\n')\n" "> \t\tse_dev->se_dev_alias[read_bytes - 1] = '\\0';\n" "> @@ -1756,6 +1758,8 @@ static ssize_t target_core_store_dev_udev_path(\n" "> \tse_dev->su_dev_flags |= SDF_USING_UDEV_PATH;\n" "> \tread_bytes = snprintf(&se_dev->se_dev_udev_path[0], SE_UDEV_PATH_LEN,\n" "> \t\t\t\"%s\", page);\n" - "> +\tif (read_bytes = 0)\n" + "> +\tif (read_bytes == 0)\n" "> +\t\treturn -EINVAL;\n" "> \n" - "> \tif (se_dev->se_dev_udev_path[read_bytes - 1] = '\\n')\n" + "> \tif (se_dev->se_dev_udev_path[read_bytes - 1] == '\\n')\n" "> \t\tse_dev->se_dev_udev_path[read_bytes - 1] = '\\0';\n" "> --\n" "> To unsubscribe from this list: send the line \"unsubscribe kernel-janitors\" in\n" @@ -54,4 +54,4 @@ "> \n" > -5f294236a17ef638b85ca0f8c9a4be22ed8043846f969e7adce2c2588622e5fd +0a00df5dde8d94111b4bb209becae1cb2de8bce7157b193d0d78257ce75da919
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.