From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:36973) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RpfGa-00024U-5o for qemu-devel@nongnu.org; Tue, 24 Jan 2012 07:14:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RpfGT-00015X-JZ for qemu-devel@nongnu.org; Tue, 24 Jan 2012 07:14:24 -0500 Message-ID: <4F1EA093.9010506@siemens.com> Date: Tue, 24 Jan 2012 13:14:11 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <4F0487EE.6090502@suse.de> <4F09C4E9.3010300@suse.de> <4F0F287B.3010009@suse.de> In-Reply-To: <4F0F287B.3010009@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] hw/vmmouse.c: Fix to disable vmmouse after reboot List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Andreas_F=E4rber?= Cc: Gerhard Wiesinger , Anthony Liguori , qemu-devel@nongnu.org, qemu-stable@nongnu.org On 2012-01-12 19:37, Andreas F=E4rber wrote: > Am 08.01.2012 17:31, schrieb Andreas F=E4rber: >> Am 08.01.2012 13:01, schrieb Gerhard Wiesinger: >>> On Wed, 4 Jan 2012, Gerhard Wiesinger wrote: >>> >>>> Testscenario: >>>> 1.) Boot e.g. OS with VMMouse support (e.g. Windows) >>>> 2.) reboot >>>> 3.) Boot e.g. OS without VMMouse support (e.g. DOS) =3D> PS/2 mouse >>>> doesn't work any more. Fixes that issue. >>>> >>>> Reason is that VMMouse has priority and disables all other mouse >>>> entities and therefore must be disabled on reset. >>> >>> Any further comments before integrating the patch? >> >> I implicitly asked you for a more verbose commit message. >> >> For example, based on the info you provided as a reply above: >> >> --8<-- >> hw/vmmouse.c: Disable vmmouse on reboot >> >> When a guest activated the vmmouse, following a reboot the vmmouse >> stayed enabled and the PS/2 mouse was unusable. That way, when rebooti= ng >> to guests without vmmouse support the mouse would not work. >> >> Fix this by disabling the vmmouse in its reset handler. >> --8<-- >=20 > I have been unable to reproduce this issue with our qemu-kvm 0.15.1. > SLES 11 uses vmmouse, whereas SLES installation does not use vmmouse. > After doing a kdump or reboot in SLES, the mouse worked just fine in > either of them. I can confirm the that this patch fixes a real issue. Setup: qemu.git, opensuse 11.4 guest, SDL graphic, system_reset while guest is using the vmmouse. Without the patch, the vmmouse become unusable after the reboot. Also, the mouse stays in absolute mode even before X starts again. So please merge. Jan --=20 Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux