From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:53501)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1RpiFP-0000yK-Er
	for qemu-devel@nongnu.org; Tue, 24 Jan 2012 10:25:29 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1RpiFI-0000Mu-Qt
	for qemu-devel@nongnu.org; Tue, 24 Jan 2012 10:25:23 -0500
Received: from goliath.siemens.de ([192.35.17.28]:31610)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1RpiFI-0000Mn-FT
	for qemu-devel@nongnu.org; Tue, 24 Jan 2012 10:25:16 -0500
Message-ID: <4F1ECD52.4000701@siemens.com>
Date: Tue, 24 Jan 2012 16:25:06 +0100
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <4F1E7190.6030608@siemens.com> <4F1ECCA2.8040003@redhat.com>
In-Reply-To: <4F1ECCA2.8040003@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] signrom: Rewrite as python script
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: Alexander Graf <agraf@suse.de>, Anthony Liguori <aliguori@us.ibm.com>, Christoph Egger <Christoph.Egger@amd.com>, qemu-devel <qemu-devel@nongnu.org>, Stefan Weil <weil@mail.berlios.de>, Paolo Bonzini <pbonzini@redhat.com>

On 2012-01-24 16:22, Eric Blake wrote:
> On 01/24/2012 01:53 AM, Jan Kiszka wrote:
>> Now that we have a hard dependency on python anyway, we can replace the
>> slow shell script to calculate the option ROM checksum with a fast AND
>> portable python version. Tested both with python 2.7 and 3.1.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>
>> +++ b/scripts/signrom.py
>> @@ -0,0 +1,40 @@
>> +#
>> +# Option ROM Signing utility
>> +#
>> +# Authors:
>> +#  Jan Kiszka <jan.kiszka@siemens.com>
>> +#
>> +# This work is licensed under the terms of the GNU GPLv2.
> 
> Any reason you aren't using GPLv2+,

Internal complications. :-/

> 
>> --- a/scripts/signrom.sh
>> +++ /dev/null
>> @@ -1,45 +0,0 @@
>> -#!/bin/sh
>> -
>> -# Option ROM Signing utility
>> -#
>> -# This program is free software; you can redistribute it and/or modify
>> -# it under the terms of the GNU General Public License as published by
>> -# the Free Software Foundation; either version 2 of the License, or
>> -# (at your option) any later version.
> 
> especially since you were replacing a more permissive license in the .sh
> version?

I'm writing new code, this is not a derivative.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux