From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:50638) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rpl1T-00080F-Ow for qemu-devel@nongnu.org; Tue, 24 Jan 2012 13:23:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rpl1P-0002gW-1t for qemu-devel@nongnu.org; Tue, 24 Jan 2012 13:23:11 -0500 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:58126) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rpl1O-0002gB-TX for qemu-devel@nongnu.org; Tue, 24 Jan 2012 13:23:07 -0500 Message-ID: <4F1EF705.30900@weilnetz.de> Date: Tue, 24 Jan 2012 19:23:01 +0100 From: Stefan Weil MIME-Version: 1.0 References: <75020d27a76d9b884a9c40d8c6ec81b525ab96a9.1327302677.git.peter.crosthwaite@petalogix.com> <4F1E5C49.4030604@suse.de> In-Reply-To: <4F1E5C49.4030604@suse.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC PATCH 5/7] vl.c: added -kerndtb option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Peter A. G. Crosthwaite" Cc: Peter Maydell , monstr@monstr.eu, edgar.iglesias@petalogix.com, qemu-devel@nongnu.org, duyl@xilinx.com, linnj@xilinx.com, =?ISO-8859-15?Q?Andreas_F=E4rber?= , john.williams@petalogix.com Am 24.01.2012 08:22, schrieb Andreas F=E4rber: > Am 23.01.2012 08:20, schrieb Peter A. G. Crosthwaite: >> Added linux specific kernel dtb option. This option can be specified=20 >> to inject >> an argument device tree blob (dtb) into linux. >> >> Signed-off-by: Peter A. G. Crosthwaite >> --- >> qemu-options.hx | 3 +++ >> vl.c | 4 ++++ >> 2 files changed, 7 insertions(+), 0 deletions(-) >> >> diff --git a/qemu-options.hx b/qemu-options.hx >> index 6295cde..43cddff 100644 >> --- a/qemu-options.hx >> +++ b/qemu-options.hx >> @@ -1931,6 +1931,9 @@ ETEXI >> >> DEF("kernel", HAS_ARG, QEMU_OPTION_kernel, \ >> "-kernel bzImage use 'bzImage' as kernel image\n", QEMU_ARCH_ALL) >> +DEF("kern-dtb", HAS_ARG, QEMU_OPTION_kerndtb, \ >> + "-kern-dtb dtb device tree blob passed to kernel boot\n",=20 >> QEMU_ARCH_ALL) > > We should probably call it -kernel-dtb. If there's some strncmp() from > -kernel interfering, we should fix that instead. > > I don't see this variable being used anywhere in this series though. > Would it have been in the missing zynq machine of 7/7? > > Andreas I'd prefer a different solution. As far as I have understood, the dtb is only useful with a kernel, so it could be handled as an optional attribute to the -kernel parameter: -kernel IMAGE[,dtb=3DDTB] Of course the same applies to -append, but that's a different issue. Regards, Stefan