From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:53563)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Rpnek-0001fx-Cd
	for qemu-devel@nongnu.org; Tue, 24 Jan 2012 16:11:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Rpnei-0002ha-I5
	for qemu-devel@nongnu.org; Tue, 24 Jan 2012 16:11:54 -0500
Message-ID: <4F1F1E91.50609@codemonkey.ws>
Date: Tue, 24 Jan 2012 15:11:45 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1327433600-7403-1-git-send-email-aliguori@us.ibm.com>	<1327433600-7403-28-git-send-email-aliguori@us.ibm.com>	<4F1F0E2D.2020706@web.de>
	<4F1F12E7.2020309@us.ibm.com> <4F1F1C28.4040600@web.de>
In-Reply-To: <4F1F1C28.4040600@web.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 27/28] sysbus: apic: ioapic: convert to
 QEMU Object Model
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <aliguori@us.ibm.com>, "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, Blue Swirl <blauwirbel@gmail.com>, =?ISO-8859-15?Q?Andreas_F=E4rber?= <andreas.faerber@web.de>, qemu-ppc@nongnu.org, Paul Brook <paul@codesourcery.com>, Aurelien Jarno <aurelien@aurel32.net>, Gerd Hoffmann <kraxel@redhat.com>

On 01/24/2012 03:01 PM, Jan Kiszka wrote:
> On 2012-01-24 21:21, Anthony Liguori wrote:
>>> Also, I see a lot of programmatic initialization and a lot of repeating
>>> patterns (specifically regarding trivial class initialization) - there
>>> is no better alternative?
>>
>> Not really, no.  It looks bad now because you have DeviceInfo still.
>> Once DeviceInfo goes away, all of the initialization will happen in the
>> class_init function.
>>
>> The design of QOM is such that a lot of what was previously done via
>> declarative structures is now done imperatively.  But the code bloat
>> that came in this patch series will decrease significantly with the next
>> series as we eliminate DeviceInfo.
>
> Are there examples of fully converted devices to get an impression?

https://github.com/aliguori/qemu/tree/qom-rebase.8

Has everything fully converted (including BusState).

If you look at qdev.[ch], you'll notice the remaining qdev infrastructure 
becomes greatly simplified.

Regards,

Anthony Liguori

>
> Jan
>