From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ike Panhc Subject: Re: [PATCH] acer-wmi: check wireless capability on AMW0_GUID2 machines Date: Wed, 25 Jan 2012 09:29:15 +0800 Message-ID: <4F1F5AEB.9080602@canonical.com> References: <1326090677-25942-1-git-send-email-jlee@suse.com> <3474148.WRXZ4siLlh@valkyrie> <1326103224.24116.282.camel@linux-s257.site> <4607313.aZXtt4raMe@valkyrie> <1326255999.16788.40.camel@linux-s257.site> <4F0DBEAE.4010707@canonical.com> <1327027494.15960.73.camel@linux-s257.site> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from youngberry.canonical.com ([91.189.89.112]:47013 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755293Ab2AYB30 (ORCPT ); Tue, 24 Jan 2012 20:29:26 -0500 In-Reply-To: <1327027494.15960.73.camel@linux-s257.site> Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: joeyli Cc: Carlos Corbacho , mjg@redhat.com, platform-driver-x86@vger.kernel.org, Dmitry Torokhov , Corentin Chary , Thomas Renninger Hi Joey, On 01/20/2012 10:44 AM, joeyli wrote: > Hi Ike >=20 > =E6=96=BC =E5=9B=9B=EF=BC=8C2012-01-12 =E6=96=BC 00:54 +0800=EF=BC=8C= Ike Panhc =E6=8F=90=E5=88=B0=EF=BC=9A >> On 01/11/2012 12:26 PM, joeyli wrote: >>> =E6=96=BC =E4=B8=80=EF=BC=8C2012-01-09 =E6=96=BC 22:15 +0000=EF=BC=8C= Carlos Corbacho =E6=8F=90=E5=88=B0=EF=BC=9A >>>> On Monday 09 Jan 2012 18:00:24 joeyli wrote: >>>>> I just checked and found I also have no AMW0_GUID2 machines on my= hand, >>>>> now. >>>>> I have some questions about AMW0_GUID2: >>>>> >>>>> + Why we enabled wireless capability in acer-wim if a non-acer = machine has >>>>> AMW0_GUID2 ? >>>> >>>> IIRC, there were some bug reports on non-Acer hardware (I don't th= ink this=20 >>>> involved Acer hardware, but this was some time ago...) where the w= ireless=20 >>>> detection wasn't working with this, but if we forced it on, it wor= ked fine. >>>> >>> >>> Yes, in acer-wmi supported some non-acer machine by quirk and read = EC >>> register. That means we need find out EC register reflect to wifi R= =46 >>> state if we are lucky. >>> >>> Unfortunately, direct enable wireless capability causes some non-ac= er >>> machines' wireless rfkill always disabled. e.g. Lenovo E520 >>> >>> https://bugzilla.redhat.com/show_bug.cgi?id=3D674353=20 >>> >>> If we don't check the wireless capability, then they need manually = add >>> acer-wmi to backlist. On some lenovo machines, ideapad-laptop drive= r >>> should support by lenovo's ACPI method. >>> >> >> I've got two reports which says after poking the ec register, the ph= y0 rfkill reports hard blocked by mistake. And few hours ago I get the = third report says the similar issue. I will summary the report. >> >=20 > Do you mean the above 2 reports is use this patch? or actually it's > other problem? > Could you please kindly test this patch on issue machines? >=20 Yes, I ask them to blacklist patched acer-wmi to confirm the problem. I am afraid that after we change the value of ec register, ec firmware = might do something unexpectedly. Since acer-wmi is loaded on lots of ma= chine with different EC, it might cause unexpected and different regres= sion on each machine. >> I am thinking about alternative way >> >> Since we have thinkpad_acpi and ideapad_laptop, both of them have rf= kill capability. If there is VPC2004/IBM0068/LEN0068 in DSDT, then it w= ill be fine if we do not register rfkill in acer-wmi. >> >> Any thought? >> >=20 > It's also another idea. >=20 >=20 > Thanks a lot! > Joey Lee >=20 >=20