From: Jehan Bing <jehan@orb.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] submodule add: fix breakage when re-adding a deep submodule
Date: Tue, 24 Jan 2012 17:48:46 -0800 [thread overview]
Message-ID: <4F1F5F7E.2000506@orb.com> (raw)
In-Reply-To: <4F1F2784.1020904@web.de>
On 2012-01-24 13:49, Jens Lehmann wrote:
> diff --git a/git-submodule.sh b/git-submodule.sh
> index 3adab93..9bb2e13 100755
> --- a/git-submodule.sh
> +++ b/git-submodule.sh
> @@ -131,6 +131,7 @@ module_clone()
> gitdir=
> gitdir_base=
> name=$(module_name "$path" 2>/dev/null)
> + test -n "$name" || name="$path"
> base_path=$(dirname "$path")
>
> gitdir=$(git rev-parse --git-dir)
That fixed my problem. Thanks Jens.
Jehan
prev parent reply other threads:[~2012-01-25 1:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-24 19:11 [BUG] Fail to add a module in a subdirectory if module is already cloned Jehan Bing
2012-01-24 21:10 ` Jens Lehmann
2012-01-24 21:13 ` Jens Lehmann
2012-01-24 21:24 ` Junio C Hamano
2012-01-24 21:44 ` Jens Lehmann
2012-01-24 22:14 ` Jens Lehmann
2012-01-24 22:38 ` Junio C Hamano
2012-01-24 21:49 ` [PATCH] submodule add: fix breakage when re-adding a deep submodule Jens Lehmann
2012-01-25 1:48 ` Jehan Bing [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F1F5F7E.2000506@orb.com \
--to=jehan@orb.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.