From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 2/2] drm/i915: drm/i915: Fix recursive calls
 to unmap
Date: Tue, 24 Jan 2012 20:02:55 -0800
Message-ID: <4F1F7EEF.2010603@bwidawsk.net>
References: <1327444923-13316-1-git-send-email-ben@bwidawsk.net>
	<1327444923-13316-2-git-send-email-ben@bwidawsk.net>
	<86ipk0ln87.fsf@sumi.keithp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from cloud01.chad-versace.us (184-106-247-128.static.cloud-ips.com
	[184.106.247.128])
	by gabe.freedesktop.org (Postfix) with ESMTP id 744979E7BB
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 24 Jan 2012 20:03:05 -0800 (PST)
In-Reply-To: <86ipk0ln87.fsf@sumi.keithp.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Keith Packard <keithp@keithp.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On 01/24/12 15:00, Keith Packard wrote:
> On Tue, 24 Jan 2012 14:42:03 -0800, Ben Widawsky<ben@bwidawsk.net>  wrote:
>
>> This patch fixes gem_unref_active_buffers from i-g-t in the non-VTd
>> case (ie. do_idle_maps forced to true).
>
> Nice, one-line fix.
>
> (if you agree with my<bikeshed>  in the previous patch, this will have
> to be changed to match)
>
> Reviewed-by: Keith Packard<keithp@keithp.com>
>

I agree with the bikeshed, however I am not sure what you expect changed 
here. do_idle_maps is still forced to true to test the fix. So I'm going 
to assume you just read the comment too quickly and resubmit with the 
updated patches.