From: Viresh Kumar <viresh.kumar@st.com>
To: Linus WALLEIJ <linus.walleij@stericsson.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Christopher BLAIR <chris.blair@stericsson.com>,
Grant Likely <grant.likely@secretlab.ca>
Subject: Re: [PATCH v2] gpio/stmpe: support no-irq mode
Date: Wed, 25 Jan 2012 16:05:37 +0530 [thread overview]
Message-ID: <4F1FDAF9.90008@st.com> (raw)
In-Reply-To: <1327485189-15522-1-git-send-email-linus.walleij@stericsson.com>
On 1/25/2012 3:23 PM, Linus WALLEIJ wrote:
> + if (!stmpe->pdata->no_irq) {
> + irq = platform_get_irq(pdev, 0);
> + if (irq < 0)
> + return irq;
> + }
I already acked it once, but there is another idea that i have :)
Why not allow passing no irqs in resource fields directly.
i.e. platform_get_irq() < 0 will automatically mean irqs are not supported
on platform and then we can do what we are doing in your patch. This will
remove need of another pdata field. :)
--
viresh
next prev parent reply other threads:[~2012-01-25 10:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-25 9:53 [PATCH v2] gpio/stmpe: support no-irq mode Linus Walleij
2012-01-25 10:35 ` Viresh Kumar [this message]
2012-01-26 6:34 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F1FDAF9.90008@st.com \
--to=viresh.kumar@st.com \
--cc=chris.blair@stericsson.com \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.