From: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
To: Jan Kiszka <jan.kiszka@domain.hid>
Cc: xenomai-core <xenomai@xenomai.org>
Subject: Re: [Xenomai-core] [PATCH] Add sigdebug unit test
Date: Wed, 25 Jan 2012 17:35:26 +0100 [thread overview]
Message-ID: <4F202F4E.6000708@domain.hid> (raw)
In-Reply-To: <4F202C11.70908@domain.hid>
On 01/25/2012 05:21 PM, Jan Kiszka wrote:
> We had two regressions in this code recently. So test all 6 possible
> SIGDEBUG reasons, or 5 if the watchdog is not available.
Ok for this test, with a few remarks:
- this is a regression test, so should go to
src/testsuite/regression(/native), and should be added to the
xeno-regression-test
- we already have a regression test for the watchdog called mayday.c,
which tests the second watchdog action, please merge mayday.c with
sigdebug.c (mayday.c also allows checking the disassembly of the code in
the mayday page, a nice feature)
- please make the watchdog test mandatory by default (adding a command
line option to skip it for instance), the test should fail if the
watchdog is not enabled, because otherwise, it will be easy to forget
testing this feature. The wathdog is enabled by default with xenomai 2.6
anyway.
--
Gilles.
next prev parent reply other threads:[~2012-01-25 16:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-25 16:21 [Xenomai-core] [PATCH] Add sigdebug unit test Jan Kiszka
2012-01-25 16:35 ` Gilles Chanteperdrix [this message]
2012-01-25 16:47 ` Jan Kiszka
2012-01-25 16:52 ` Jan Kiszka
2012-01-25 17:02 ` Gilles Chanteperdrix
2012-01-25 17:10 ` Jan Kiszka
2012-01-25 17:44 ` Gilles Chanteperdrix
2012-01-25 18:05 ` Jan Kiszka
2012-01-26 10:36 ` Jan Kiszka
2012-01-26 11:20 ` Philippe Gerum
2012-01-26 12:56 ` Jan Kiszka
2012-01-26 14:36 ` Jan Kiszka
2012-01-26 15:39 ` Jan Kiszka
2012-01-26 14:55 ` Gilles Chanteperdrix
2012-01-26 15:06 ` Jan Kiszka
2012-01-26 15:52 ` Gilles Chanteperdrix
2012-01-26 16:11 ` Jan Kiszka
2012-01-26 16:41 ` Gilles Chanteperdrix
2012-01-25 22:18 ` Gilles Chanteperdrix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F202F4E.6000708@domain.hid \
--to=gilles.chanteperdrix@xenomai.org \
--cc=jan.kiszka@domain.hid \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.