From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH] drm/i915: fixup forcewake spinlock fallout in drpc debugfs function Date: Wed, 25 Jan 2012 08:45:27 -0800 Message-ID: <4F2031A7.4080903@bwidawsk.net> References: <1327495963-2794-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from cloud01.chad-versace.us (184-106-247-128.static.cloud-ips.com [184.106.247.128]) by gabe.freedesktop.org (Postfix) with ESMTP id 73BE79E790 for ; Wed, 25 Jan 2012 08:45:36 -0800 (PST) In-Reply-To: <1327495963-2794-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On 01/25/12 04:52, Daniel Vetter wrote: > My forcewake spinlock patches have a functional conflict with Ben > Widawsky's gen6 drpc support for debugfs. Result was a benign warning > about trying to read an non-atomic variabla with atomic_read. > > Note that the entire check is racy anyway and purely informational. > Also update it to reflect the forcewake voodoo changes, the kernel can > now also hold onto a forcewake reference for longer times. > > Signed-Off-by: Daniel Vetter Reviewed-by: Ben Widawsky