From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:53284)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Rq6JQ-0005Gj-Cs
	for qemu-devel@nongnu.org; Wed, 25 Jan 2012 12:07:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Rq6JO-0005OZ-Mz
	for qemu-devel@nongnu.org; Wed, 25 Jan 2012 12:07:08 -0500
Received: from cantor2.suse.de ([195.135.220.15]:48031 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Rq6JO-0005OV-BW
	for qemu-devel@nongnu.org; Wed, 25 Jan 2012 12:07:06 -0500
Message-ID: <4F203639.3000101@suse.de>
Date: Wed, 25 Jan 2012 18:04:57 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1327056829-24491-1-git-send-email-e.voevodin@samsung.com>
	<1327056829-24491-8-git-send-email-e.voevodin@samsung.com>
	<CAFEAcA-kFKHxdP0-75OMpZ2KCPPPSusGd5mMNk16dK5TvQwcCQ@mail.gmail.com>
In-Reply-To: <CAFEAcA-kFKHxdP0-75OMpZ2KCPPPSusGd5mMNk16dK5TvQwcCQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v9 7/9] hw/lan9118: Add basic 16-bit mode
 support.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Evgeny Voevodin <e.voevodin@samsung.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, kyungmin.park@samsung.com, d.solodkiy@samsung.com, m.kozlov@samsung.com, jehyung.lee@samsung.com

Am 25.01.2012 17:35, schrieb Peter Maydell:
> On 20 January 2012 10:53, Evgeny Voevodin <e.voevodin@samsung.com> wrot=
e:
>> @@ -294,6 +304,14 @@ static const VMStateDescription vmstate_lan9118 =3D=
 {
>>         VMSTATE_INT32(rxp_offset, lan9118_state),
>>         VMSTATE_INT32(rxp_size, lan9118_state),
>>         VMSTATE_INT32(rxp_pad, lan9118_state),
>> +        VMSTATE_UINT32(write_word_prev_offset, lan9118_state),
>> +        VMSTATE_UINT32(write_word_n, lan9118_state),
>> +        VMSTATE_UINT16(write_word_l, lan9118_state),
>> +        VMSTATE_UINT16(write_word_h, lan9118_state),
>> +        VMSTATE_UINT32(read_word_prev_offset, lan9118_state),
>> +        VMSTATE_UINT32(read_word_n, lan9118_state),
>> +        VMSTATE_UINT32(read_long, lan9118_state),
>> +        VMSTATE_UINT32(mode_16bit, lan9118_state),
>>         VMSTATE_END_OF_LIST()
>=20
> You need to bump .version_id and make your new fields
>    VMSTATE_UINT32(write_word_prev_offset, lan9118_state, 2),

    VMSTATE_UINT32_V(write_word_prev_offset, lan9118_state, 2),

> etc.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg