Re: [Qemu-devel] [PATCH v2 6/9] hw/vexpress.c: Factor out daughterboard-specific initialization

["Andreas Färber" <afaerber@suse.de>]

Am 24.01.2012 13:39, schrieb Peter Maydell:
> Factor out daughterboard specifics into a data structure and
> daughterboard initialization function, in preparation for adding
> vexpress-a15 support.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  hw/vexpress.c |  118 ++++++++++++++++++++++++++++++++++++++++-----------------
>  1 files changed, 83 insertions(+), 35 deletions(-)
> 
> diff --git a/hw/vexpress.c b/hw/vexpress.c
> index 99a9690..9033b50 100644
> --- a/hw/vexpress.c
> +++ b/hw/vexpress.c

> +struct VEDBoardInfo {
> +    const target_phys_addr_t *motherboard_map;
> +    const target_phys_addr_t loader_start;

const for a value type in a struct looks fishy...is it intentional and
valid C99?

Otherwise looks okay.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg