From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 04/21] ARM: omap2+: smartreflex: move smartreflex suspend to suspend_noirq Date: Wed, 25 Jan 2012 21:29:49 +0300 Message-ID: <4F204A1D.4090005@ru.mvista.com> References: <1327504583-13408-1-git-send-email-j-pihet@ti.com> <1327504583-13408-5-git-send-email-j-pihet@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail.dev.rtsoft.ru ([213.79.90.226]:45825 "HELO mail.dev.rtsoft.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1756463Ab2AYRa7 (ORCPT ); Wed, 25 Jan 2012 12:30:59 -0500 In-Reply-To: <1327504583-13408-5-git-send-email-j-pihet@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Jean Pihet Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, balbi@ti.com, nm@ti.com, Kevin Hilman , Paul Walmsley , Jean Pihet , Colin Cross On 01/25/2012 06:16 PM, Jean Pihet wrote: > From: Colin Cross > Running without smartreflex for any significant time (on the order > of seconds) is unsafe and can cause thermal runaway. Move > smartreflex suspend into suspend_noirq, so it happens as late as > possible. This prevents hangs that occur in a driver suspend > handler from running without smartreflex enabled. It will also > reduce power used during suspend and resume, as the voltages will > be lowered. > May also indirectly fix imprecise external aborts seen during > suspend, which could be caused by calls to sr_disable racing > from calls to dvfs_scale and omap_sr_disable. > Change-Id: Ia3c1e707bb1022ec102f506dc3ad48906e8890da This line has no place in the upstream commit. Please remove. WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: sshtylyov@ru.mvista.com (Sergei Shtylyov) Date: Wed, 25 Jan 2012 21:29:49 +0300 Subject: [PATCH 04/21] ARM: omap2+: smartreflex: move smartreflex suspend to suspend_noirq In-Reply-To: <1327504583-13408-5-git-send-email-j-pihet@ti.com> References: <1327504583-13408-1-git-send-email-j-pihet@ti.com> <1327504583-13408-5-git-send-email-j-pihet@ti.com> Message-ID: <4F204A1D.4090005@ru.mvista.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 01/25/2012 06:16 PM, Jean Pihet wrote: > From: Colin Cross > Running without smartreflex for any significant time (on the order > of seconds) is unsafe and can cause thermal runaway. Move > smartreflex suspend into suspend_noirq, so it happens as late as > possible. This prevents hangs that occur in a driver suspend > handler from running without smartreflex enabled. It will also > reduce power used during suspend and resume, as the voltages will > be lowered. > May also indirectly fix imprecise external aborts seen during > suspend, which could be caused by calls to sr_disable racing > from calls to dvfs_scale and omap_sr_disable. > Change-Id: Ia3c1e707bb1022ec102f506dc3ad48906e8890da This line has no place in the upstream commit. Please remove. WBR, Sergei