All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boaz Harrosh <bharrosh@panasas.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>,
	linux-scsi <linux-scsi@vger.kernel.org>,
	open-osd <osd-dev@open-osd.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Al Viro <viro@ZenIV.linux.org.uk>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: "Welch, Brent" <welch@panasas.com>,
	"Bhamare, Sachin" <sbhamare@panasas.com>,
	Stable Tree <stable@vger.kernel.org>
Subject: [PATCHSET 0/1] osd_uld: Important fix also for 3.2 Stable
Date: Wed, 25 Jan 2012 21:40:31 +0200	[thread overview]
Message-ID: <4F205AAF.7000305@panasas.com> (raw)


There was a mine hiding in the osd_uld driver. It was limited by the number of device minors
it registers at startup which was 64.

The rest of the code is not limited at all and can hold as many devices as permitted
by memory conditions.

The fix is very simple just bump the max number to the maximum minor permitted which
is 2^20.

This is a serious BUG because some of the systems that intend to use the 3.2 Kernel
to deploy pnfs. (Fedora 17 most probably) are bigger then 64 OSDs and will break.

I have tested this on 64bit platform and user-mode works just fine with this.
(Kernel is not an issue). Might there be issues hiding in 32bit ARCHs. From
reading the code I could not find any.

James would you like to take this through your tree for the next rc-fixes round
or give me an ACK-BY: and I'll push it through the osd tree?

The patch:
[PATCH 1/1] osd_uld: Bump MAX_OSD_DEVICES from 64 to 1,048,576

Thanks
Boaz


             reply	other threads:[~2012-01-25 19:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-25 19:40 Boaz Harrosh [this message]
2012-01-25 19:42 ` [PATCH 1/1] osd_uld: Bump MAX_OSD_DEVICES from 64 to 1,048,576 Boaz Harrosh
2012-02-01 15:50   ` Boaz Harrosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F205AAF.7000305@panasas.com \
    --to=bharrosh@panasas.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=osd-dev@open-osd.org \
    --cc=sbhamare@panasas.com \
    --cc=stable@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    --cc=welch@panasas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.