From mboxrd@z Thu Jan 1 00:00:00 1970 From: Philip Prindeville Subject: Re: [PATCH v3 1/1] alix2: supplement driver to include GPIO button support Date: Wed, 25 Jan 2012 16:04:16 -0700 Message-ID: <4F208A70.1050709@redfish-solutions.com> References: <1327348589-9601-1-git-send-email-philipp@redfish-solutions.com> <20120125145742.338086b8.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mail.redfish-solutions.com ([66.232.79.143]:53550 "EHLO mail.redfish-solutions.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750880Ab2AYXEs (ORCPT ); Wed, 25 Jan 2012 18:04:48 -0500 In-Reply-To: <20120125145742.338086b8.akpm@linux-foundation.org> Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: Andrew Morton Cc: platform-driver-x86@vger.kernel.org, Alessandro Zummo , Richard Purdie , Andres Salomon , Ed Wildgoose , David Woodhouse On 1/25/12 3:57 PM, Andrew Morton wrote: > On Mon, 23 Jan 2012 12:56:29 -0700 > Philip Prindeville wrote: > >> From: "Philip A. Prindeville" >> >> GPIO 24 is used in reference designs as a soft-reset button, and >> the alix2 is no exception. Add it as a gpio-button. >> >> Use symbolic values to describe BIOS addresses. >> >> Record the model number. >> >> Redux: address Andres' review comments; make the model number exported; >> add support for DMI detection of the board and manufacturer; change >> detection return type to bool; add comment explaining that the model >> number is used by downstream drivers to detect if we have RFKILL GPIO >> line to mini-PCIe slots (alix 6 only). >> >> >> ... >> >> arch/x86/platform/geode/alix.c | 80 +++++++++++++++++++++++++++++++++++++-- >> 1 files changed, 75 insertions(+), 5 deletions(-) >> >> --- a/arch/x86/platform/geode/alix.c >> +++ b/arch/x86/platform/geode/alix.c >> >> ... >> >> @@ -24,14 +25,55 @@ >> #include >> #include >> #include >> +#include >> +#include >> +#include >> >> #include >> >> +#define BIOS_SIGNATURE_TINYBIOS 0xf0000 >> +#define BIOS_SIGNATURE_COREBOOT 0x500 >> +#define BIOS_REGION_SIZE 0x10000 >> + >> +/* >> + * the 6F2 has an RFKILL GPIO line to the mini-PCIe slots that isn't >> + * present on other Alix boards. Wifi drivers can use this symbol to >> + * detect if it's available. >> + */ >> +int alix_model; >> +EXPORT_SYMBOL(alix_model); > > This is odd. There are no references to this from outside this file > and it's hard to see how a wireless driver could use this - any such > driver would have to load this module on *all* machines (even non-x86) > simply to resolve this symbol. It's for an out-of-tree driver that's only ever built for Alix hardware. Since it's only 4 bytes and one exported symbol, I figured it was acceptable... I can remove it, resubmit, and use a patch locally in my tree if that's preferable. -Philip > >> >> ... >>