From: Philip Prindeville <philipp@redfish-solutions.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: platform-driver-x86@vger.kernel.org,
Alessandro Zummo <a.zummo@towertech.it>,
Richard Purdie <rpurdie@rpsys.net>,
Andres Salomon <dilinger@queued.net>,
Ed Wildgoose <kernel@wildgooses.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH v3 1/1] alix2: supplement driver to include GPIO button support
Date: Wed, 25 Jan 2012 18:37:17 -0700 [thread overview]
Message-ID: <4F20AE4D.2040906@redfish-solutions.com> (raw)
In-Reply-To: <20120125170859.49cbf10b.akpm@linux-foundation.org>
On 1/25/12 6:08 PM, Andrew Morton wrote:
>>> Out-of-tree drivers are unpopular. Where is this driver, what is its
>>> license and what are the prospects of making it in-tree?
>>
>> It's complicated. Generic GPIO supports polled-keys for input, and LEDs for outputs as you know.
>>
>> There's no generic output mechanism for (say) an RFKILL line on the bus. If/when this materialized, I'll modify the alix driver to register that device in addition to the soft-reset button and the output LEDs (for the alix.6 device only).
>>
>> There's also a certain amount of churn going on right now in coreboot about supporting the 'alix.6' as a variant of the 'alix.2' (the coreboot build machinery doesn't support this, and we need to hack kconfig to make this happen, i.e. have kconfig be queryable from shell scripts like coreboot's abuild)... so for now most people burn an alix.2 coreboot image onto their alix.6.
>>
>> So there's a chain of dependencies that need to be resolved to get the ideal solution in place... but not wanting the perfect be the enemy of the good, I wanted to get what's available today out there with the caveat that something better is in the pipeline.
>
> That didn't really answer my question about the whereabouts of the
> mystery wireless driver. Oh well, it doesn't matter much.
Oh, yeah, sorry. The driver is currently only in my tree, though I had wanted to get it into OpenWRT but after having even linux-atm upstream patches not get retrofitted into the OpenWRT sources, I've given up on submitting additional patches.
The short answer was that in a perfect world, I won't need the out-of-tree driver and will be able to do everything in the alix2.c platform driver when GPIO support for non-button-or-LED-thingies gets added... at which point alix_model can be deprecated.
>>> I don't personally have problems with helping out-of-tree drivers but
>>> making it EXPORT_SYMBOL_GPL() would set minds at rest.
>>
>> Ok. I'll make that patch and resubmit...
>
> Add a comment there too, otherwise someone will come along and zap it.
>
Ok, will do.
next prev parent reply other threads:[~2012-01-26 1:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 19:56 [PATCH v3 1/1] alix2: supplement driver to include GPIO button support Philip Prindeville
2012-01-23 22:56 ` Andres Salomon
2012-01-25 22:57 ` Andrew Morton
2012-01-25 23:04 ` Philip Prindeville
2012-01-25 23:16 ` Andrew Morton
2012-01-25 23:47 ` Philip Prindeville
2012-01-26 1:08 ` Andrew Morton
2012-01-26 1:37 ` Philip Prindeville [this message]
2012-01-26 10:15 ` Ed Wildgoose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F20AE4D.2040906@redfish-solutions.com \
--to=philipp@redfish-solutions.com \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=dilinger@queued.net \
--cc=dwmw2@infradead.org \
--cc=kernel@wildgooses.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.