From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel <qemu-devel@nongnu.org>, Kevin Wolf <kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] scsi: Guard against buflen exceeding req->cmd.xfer in scsi_disk_emulate_command
Date: Thu, 26 Jan 2012 08:50:09 +0100 [thread overview]
Message-ID: <4F2105B1.7070706@redhat.com> (raw)
In-Reply-To: <20120124171944.GD14494@akamai.com>
On 01/24/2012 06:19 PM, Thomas Higdon wrote:
> I agree that it's better to get this into a more general place. However,
> I wasn't willing to pull the MIN statement up into scsi_send_command
> because I don't understand the interplay between 'len' in that function
> and r->iov.iov_len. I couldn't see that there was a general relationship
> between these two variables that applied to both read/write commands and
> other commands.
That's good enough, and it should fix also the bugs with GET
CONFIGURATION that Artyom reported. Two birds with a stone!
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Kevin, shall I take this patch in the virtio-scsi series? I'll have to
resubmit anyway due to the QOM changes.
Paolo
next prev parent reply other threads:[~2012-01-26 7:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 17:15 [Qemu-trivial] [PATCH] scsi: restrict buffer length to req->cmd.xfer for responses to INQUIRY commands Thomas Higdon
2012-01-23 17:15 ` [Qemu-devel] " Thomas Higdon
2012-01-23 17:47 ` [Qemu-trivial] " Paolo Bonzini
2012-01-23 17:47 ` [Qemu-devel] " Paolo Bonzini
2012-01-23 18:14 ` [Qemu-trivial] " Thomas Higdon
2012-01-23 18:14 ` [Qemu-devel] " Thomas Higdon
2012-01-24 8:21 ` [Qemu-trivial] " Paolo Bonzini
2012-01-24 8:21 ` [Qemu-devel] " Paolo Bonzini
2012-01-24 13:53 ` [Qemu-trivial] " Kevin Wolf
2012-01-24 13:53 ` [Qemu-devel] " Kevin Wolf
2012-01-24 17:19 ` [Qemu-trivial] [PATCH] scsi: Guard against buflen exceeding req->cmd.xfer in scsi_disk_emulate_command Thomas Higdon
2012-01-24 17:19 ` [Qemu-devel] " Thomas Higdon
2012-01-26 7:50 ` Paolo Bonzini [this message]
2012-01-26 10:41 ` Kevin Wolf
2012-01-26 10:53 ` Paolo Bonzini
2012-01-27 5:59 ` [Qemu-trivial] " Stefan Hajnoczi
2012-01-27 5:59 ` [Qemu-devel] " Stefan Hajnoczi
2012-01-27 8:44 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2105B1.7070706@redhat.com \
--to=pbonzini@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.