All of lore.kernel.org
 help / color / mirror / Atom feed
From: Srinivas KANDAGATLA <srinivas.kandagatla@st.com>
To: Jim Rees <rees@umich.edu>
Cc: linux-nfs@vger.kernel.org, akpm@linux-foundation.org,
	mingo@redhat.com, neilb@suse.de, stuart.menefy@st.com
Subject: Re: [RFC:PATCH 3.1.0] do_mount: Add mount retry option for nfs root mount.
Date: Thu, 26 Jan 2012 07:56:11 +0000	[thread overview]
Message-ID: <4F21071B.4070000@st.com> (raw)
In-Reply-To: <20120125154539.GA20734@umich.edu>

Jim Rees wrote:
> Srinivas KANDAGATLA wrote:
>
>   From: Srinivas Kandagatla <srinivas.kandagatla@st.com>
>   
>   This patch adds mountretry kernel parameter for nfs root mount.
>   mount retry indicates the number of times nfs root mount attempts to be
>   made before giving up. If this option is not specified, the default
>   value of 3 retries is used.
>
> This has already been fixed in commit 43717c7d, "NFS: Retry mounting
> NFSROOT".  The retry count is fixed at 5.  Is there some reason you think
> the retry count should be configurable?
>   
Thanks for pointing to the fixed commit. I did realize soon after
sending this patch to mailing list.

Only reason I can think of having retry count configurable is, an
arbitrary number(3 or 5 or n) of retry count may not be enough to
address all the use cases.
So, I think the user should be given a chance to configure the retry
count if he wish to, either timeout quickly and try the succession
root-mount or If he wish to keep kernel trying very harder till he gets
the NFS root mount successful.

Thanks,
srini

  reply	other threads:[~2012-01-26  8:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-25 14:50 [RFC:PATCH 3.1.0] do_mount: Add mount retry option for nfs root mount Srinivas KANDAGATLA
2012-01-25 15:45 ` Jim Rees
2012-01-26  7:56   ` Srinivas KANDAGATLA [this message]
2012-01-26  8:37     ` Boaz Harrosh
2012-01-26  8:51       ` Srinivas KANDAGATLA
2012-01-26 11:08         ` Boaz Harrosh
2012-01-26 14:35           ` Srinivas KANDAGATLA
2012-01-25 16:20 ` Boaz Harrosh
2012-01-25 18:32   ` Jim Rees
2012-01-25 18:51     ` Boaz Harrosh
2012-01-25 18:52     ` Chuck Lever
2012-01-25 19:04       ` Boaz Harrosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F21071B.4070000@st.com \
    --to=srinivas.kandagatla@st.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=neilb@suse.de \
    --cc=rees@umich.edu \
    --cc=stuart.menefy@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.