From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:35658) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RqKh9-0005Gf-5O for qemu-devel@nongnu.org; Thu, 26 Jan 2012 03:28:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RqKh7-0008U0-J7 for qemu-devel@nongnu.org; Thu, 26 Jan 2012 03:28:35 -0500 Received: from cantor2.suse.de ([195.135.220.15]:60014 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RqKh7-0008To-9x for qemu-devel@nongnu.org; Thu, 26 Jan 2012 03:28:33 -0500 Message-ID: <4F210E2F.5040706@suse.de> Date: Thu, 26 Jan 2012 09:26:23 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] hw/vmmouse.c: Disable vmmouse after reboot List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerhard Wiesinger , Jan Kiszka Cc: qemu-devel@nongnu.org Am 25.01.2012 21:04, schrieb Gerhard Wiesinger: > Bugfix after reboot when vmmouse was enabled and another OS which uses > e.g. PS/2 > mouse. >=20 > Details: > When a guest activated the vmmouse followed by a reboot the vmmouse was > still > enabled and the PS/2 mouse was therefore unsusable. When another guest > is then > booted without vmmouse support (e.g. PS/2 mouse) the mouse is not worki= ng. >=20 > Reason is that VMMouse has priority and disables all other mouse entiti= es > and therefore must be disabled on reset. >=20 > Testscenario: > 1.) Boot e.g. OS with VMMouse support (e.g. Windows with VMMouse tools) > 2.) reboot > 3.) Boot e.g. OS without VMMouse support (e.g. DOS) =3D> PS/2 mouse > doesn't work > any more. Fixes that issue. >=20 > Testscenario 2 by Jan Kiszka : > Confirm that this patch fixes a real issue. Setup: qemu.git, > opensuse 11.4 guest, SDL graphic, system_reset while guest is using the > vmmouse. Without the patch, the vmmouse become unusable after the > reboot. Also, the mouse stays in absolute mode even before X starts aga= in. >=20 > Fixed by: > Disabling the vmmouse in its reset handler. >=20 > Signed-off-by: Gerhard Wiesinger I've been able to reproduce this the day before yesterday, on my version of qemu-kvm 0.15.1 with this patch apparently fixing the mouse after a kdump. Yesterday however the reporter applied the patch himself to qemu.git and reported this patch not to fix it on their side. We boot into the desktop, then do: # echo 1 > /proc/sys/kernel/sysrq # echo c > /proc/sysrq-trigger System then reboots after a while and at login mouse does or does not wor= k. I had originally tried to kdump with just a virtio drive w/ default settings; then I tried with the reporter's setting of -smp 4 (and cache=3Dunsafe) and was able to reproduce it. Afterwards I was able to reproduce without -smp 4 as well; no recompilation occurred. Guest was the same SLES11 SP2 RC2 all the time. So, is there any indeterminism involved? I.e. is the mouse unusability maybe not 100% reproducible? Anything else that may need to be fixed beyond this patch? Patch does not break anything, so for now: Tested-by: Andreas F=E4rber Thanks, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg