Re: [LTP] [PATCH] {tcp_cmds/echo, math/float}: Include missing usctest.h header

[Markos Chandras <Markos.Chandras@imgtec.com>]

On 01/09/2012 10:57 AM, Markos Chandras wrote:

> The tst_print function is using the TEST_ERRNO symbol which is declared
> as 'extern int' on usctest.h header when _USC_LIB_ macro is used and as 'int'
> when this macro is not defined. We need to include this header on float and
> echoes tests to ensure that TEST_ERRNO has been defined before calling
> the tst_print function. Without this header, the compilation will fail with
> an undefined symbol error.
> 
> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
> ---
>  testcases/misc/math/float/main.c         |    1 +
>  testcases/network/tcp_cmds/echo/echoes.c |    3 ++-
>  2 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/testcases/misc/math/float/main.c b/testcases/misc/math/float/main.c
> index 8998c33..870661b 100644
> --- a/testcases/misc/math/float/main.c
> +++ b/testcases/misc/math/float/main.c
> @@ -26,6 +26,7 @@
>  #include "tfloat.h"
>  
>  #include "test.h"
> +#include "usctest.h"
>  
>  #define SAFE_FREE(p) { if (p) { free(p); (p)=NULL; } }
>  /* LTP status reporting */
> diff --git a/testcases/network/tcp_cmds/echo/echoes.c b/testcases/network/tcp_cmds/echo/echoes.c
> index 877cfa5..2ce7968 100644
> --- a/testcases/network/tcp_cmds/echo/echoes.c
> +++ b/testcases/network/tcp_cmds/echo/echoes.c
> @@ -29,6 +29,7 @@
>  #include <fcntl.h>
>  #include "test.h"
>  #include "netdefs.h"
> +#include "usctest.h"
>  
>  #if INET6
>  char *TCID = "echoes6";
> @@ -372,4 +373,4 @@ void
>  cleanup(int s)
>  {
>  	close(s);
> -}
> \ No newline at end of file
> +}

Ping?

Any comments on that? Compilation fails without that when using UCLINUX=1

-- 
markos


------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list