From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC Patch] e1000: Fix PCI memory addressing and fix for receive data polling
Date: Thu, 26 Jan 2012 16:52:33 +0100 [thread overview]
Message-ID: <4F2176C1.70106@denx.de> (raw)
In-Reply-To: <4F2152F5.2040408@rw-gmbh.de>
On 26/01/2012 14:19, Ralf R?sch wrote:
> Sorry, you will find now my fixes in attachment
>
> Hi all,
Hi Ralf,
>
> I had some problem when using your e1000-code on a MIPS target.
> Attached you will find two fixes which I would like to propose for
> discussion.
>
> - Fix 1: this has the same reason as in commit
> f81ecb5d3300bf92d17302d3712f30585c182da9
Anyway, can you also describe *which* bug / behavior have you found ?
> - Fix 2: has to do with "C Language Operator Precedence".
> I would say the expression taken by the ! operator has precedence before
> the & operator.
> So any bit in rd->status other than E1000_RXD_STAT_DD stops correct
> detection of data reception.
> (What i do not know is, if it is possible that any other bit than
> E1000_RXD_STAT_DD can get active)
This seems to me a bug. However, you must send right patches for review
/ discussion. You find two issues, and you must send one patch for each
issue that will be fixed. Please have a look at:
http://www.denx.de/wiki/U-Boot/Patches
It describes how to submit patches in the right format.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
next prev parent reply other threads:[~2012-01-26 15:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 13:19 [U-Boot] [RFC Patch] e1000: Fix PCI memory addressing and fix for receive data polling Ralf Rösch
2012-01-26 15:52 ` Stefano Babic [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-01-26 9:31 Ralf Rösch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2176C1.70106@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.