diff for duplicates of <4F22624E.2090201@renesas.com> diff --git a/a/1.txt b/N1/1.txt index 24ef914..4ad18b8 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -20,7 +20,7 @@ I tested this driver on 2 environment, but it could not work correctly. In this case, should we modify the renesas_usbhs driver? For reference, if I changed the threaded IRQ to tasklet, the 2 environment worked correctly: -============== +======= diff --git a/drivers/dma/dma-simple.c b/drivers/dma/dma-simple.c index 49d8f7d..65a5170 100644 --- a/drivers/dma/dma-simple.c @@ -31,7 +31,7 @@ index 49d8f7d..65a5170 100644 - ret = ops->chan_irq(schan, irq) ? IRQ_WAKE_THREAD : IRQ_NONE; + ret = ops->chan_irq(schan, irq) ? IRQ_HANDLED : IRQ_NONE; -+ if (ret == IRQ_HANDLED) ++ if (ret = IRQ_HANDLED) + tasklet_schedule(&schan->tasklet); spin_unlock(&schan->chan_lock); @@ -44,8 +44,7 @@ index 49d8f7d..65a5170 100644 { - struct dma_simple_chan *schan = dev; + struct dma_simple_chan *schan = (struct dma_simple_chan *)dev; - const struct dma_simple_ops *ops = - to_simple_dev(schan->dma_chan.device)->ops; + const struct dma_simple_ops *ops to_simple_dev(schan->dma_chan.device)->ops; struct dma_simple_desc *sdesc; @@ -744,15 +746,13 @@ static irqreturn_t chan_irqt(int irq, void *dev) spin_unlock_irq(&schan->chan_lock); @@ -77,7 +76,7 @@ index 5336674..beb1489 100644 }; /** -============== +======= Best regards, Yoshihiro Shimoda diff --git a/a/content_digest b/N1/content_digest index d63b61d..cff9302 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\01327589784-4287-2-git-send-email-g.liakhovetski@gmx.de\0" "From\0Shimoda, Yoshihiro <yoshihiro.shimoda.uh@renesas.com>\0" "Subject\0Re: [PATCH 1/7 v2] dmaengine: add a simple dma library\0" - "Date\0Fri, 27 Jan 2012 17:37:34 +0900\0" + "Date\0Fri, 27 Jan 2012 08:37:34 +0000\0" "To\0Guennadi Liakhovetski <g.liakhovetski@gmx.de>\0" "Cc\0linux-kernel@vger.kernel.org" linux-sh@vger.kernel.org @@ -36,7 +36,7 @@ "In this case, should we modify the renesas_usbhs driver?\n" "For reference, if I changed the threaded IRQ to tasklet,\n" "the 2 environment worked correctly:\n" - "==============\n" + "=======\n" "diff --git a/drivers/dma/dma-simple.c b/drivers/dma/dma-simple.c\n" "index 49d8f7d..65a5170 100644\n" "--- a/drivers/dma/dma-simple.c\n" @@ -47,7 +47,7 @@ "\n" "-\tret = ops->chan_irq(schan, irq) ? IRQ_WAKE_THREAD : IRQ_NONE;\n" "+\tret = ops->chan_irq(schan, irq) ? IRQ_HANDLED : IRQ_NONE;\n" - "+\tif (ret == IRQ_HANDLED)\n" + "+\tif (ret = IRQ_HANDLED)\n" "+\t\ttasklet_schedule(&schan->tasklet);\n" "\n" " \tspin_unlock(&schan->chan_lock);\n" @@ -60,8 +60,7 @@ " {\n" "-\tstruct dma_simple_chan *schan = dev;\n" "+\tstruct dma_simple_chan *schan = (struct dma_simple_chan *)dev;\n" - " \tconst struct dma_simple_ops *ops =\n" - " \t\tto_simple_dev(schan->dma_chan.device)->ops;\n" + " \tconst struct dma_simple_ops *ops \t\tto_simple_dev(schan->dma_chan.device)->ops;\n" " \tstruct dma_simple_desc *sdesc;\n" "@@ -744,15 +746,13 @@ static irqreturn_t chan_irqt(int irq, void *dev)\n" " \tspin_unlock_irq(&schan->chan_lock);\n" @@ -93,9 +92,9 @@ " };\n" "\n" " /**\n" - "==============\n" + "=======\n" "\n" "Best regards,\n" Yoshihiro Shimoda -f5d5d3655f1a564d779e59453e167701b9c49e2c192242f60f98377d6064a2a9 +3db563a4782077c928f78b9433d87d52d71ee593cf05e7f5c60a2e0afef47e9f
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.