From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:41249) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RqhWJ-0008HI-Rj for qemu-devel@nongnu.org; Fri, 27 Jan 2012 03:50:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RqhWC-0001pD-65 for qemu-devel@nongnu.org; Fri, 27 Jan 2012 03:50:55 -0500 Received: from thoth.sbs.de ([192.35.17.2]:32729) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RqhWB-0001ot-Qi for qemu-devel@nongnu.org; Fri, 27 Jan 2012 03:50:48 -0500 Message-ID: <4F226562.6010300@siemens.com> Date: Fri, 27 Jan 2012 09:50:42 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <1327604460-31142-1-git-send-email-aliguori@us.ibm.com> <1327604460-31142-2-git-send-email-aliguori@us.ibm.com> In-Reply-To: <1327604460-31142-2-git-send-email-aliguori@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 01/15] pc: merge pc_piix.c into pc.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Peter Maydell , Avi Kivity , Paolo Bonzini , qemu-devel@nongnu.org, Markus Armbruster On 2012-01-26 20:00, Anthony Liguori wrote: > A long time ago, there was a grand plan to merge q35 chipset support. The start > of that series was a refactoring of pc.c which split a bunch of the "common" > functionality into a separate file that could be shared by the two. > > But q35 never got merged and the refactoring, in retrospect, just made things > worse. Making things proper objects and using composition is the right way > to share common devices. > > By pulling these files back together, we can start to fix some of this mess. There are surely things to clean up and improve, but a clear NACK for the general direction. It's undoubted that we need a more modern chipset than this ancient PIIX3, rather sooner than later. And it is clear that there is a good amount of generic functions in pc.c for building a PC, even a fairly modern one. So we need a common lib for PC chipsets and would only revert what you start here. Please name what you do not like, and then we can fix that concretely. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux