All of lore.kernel.org
 help / color / mirror / Atom feed
From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org,
	linux-rt-users <linux-rt-users@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Carsten Emde <C.Emde@osadl.org>, John Kacur <jkacur@redhat.com>,
	Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Alexander van Heukelum <heukelum@fastmail.fm>,
	Andi Kleen <ak@linux.intel.com>, Oleg Nesterov <oleg@redhat.com>,
	Clark Williams <williams@redhat.com>,
	Luis Goncalves <lgoncalv@redhat.com>
Subject: Re: [PATCH RT 1/2 v2] x86: Do not disable preemption in int3 on 32bit
Date: Fri, 27 Jan 2012 18:36:38 +0900	[thread overview]
Message-ID: <4F227026.3000508@hitachi.com> (raw)
In-Reply-To: <1327587719.22710.95.camel@gandalf.stny.rr.com>

(2012/01/26 23:21), Steven Rostedt wrote:
> On Thu, 2012-01-26 at 22:59 +0900, Masami Hiramatsu wrote:
> 
>> Better. If the functions are only for signaling, how
>> about using the "signal" in name? :)
>>
>> conditional_sti/cli_for_signal()
> 
> I don't think they are only for signals. The conditional_sti/cli is for
> all callers of do_trap(). But those callers that run on an IST stack use
> the preempt_conditional_sti/cli() code. Perhaps we should call it:
> 
> conditional_sti/cli_ist() ?
> 
> Actually, I think this is the best name. The "preempt_" one, didn't give
> any annotation about why it was disabling preemption. It was done
> because the stack is on the IST and we can not schedule out. Thus, if we
> add the "_ist()" to it, not only does it annotate why this call is
> special, but also allows x86_32, which does not have an IST, not to have
> to disable preemption.

I agree with your opinion :)

Thanks,

-- 
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com

  reply	other threads:[~2012-01-27  9:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-25 14:32 [PATCH RT 0/2 v2] preempt-rt/x86: Handle sending signals from do_trap() by gdb Steven Rostedt
2012-01-25 14:32 ` [PATCH RT 1/2 v2] x86: Do not disable preemption in int3 on 32bit Steven Rostedt
2012-01-26  8:39   ` Masami Hiramatsu
2012-01-26 13:33     ` Steven Rostedt
2012-01-26 13:59       ` Masami Hiramatsu
2012-01-26 14:21         ` Steven Rostedt
2012-01-27  9:36           ` Masami Hiramatsu [this message]
2012-01-25 14:32 ` [PATCH RT 2/2 v2] preempt-rt/x86: Delay calling signals in int3 Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F227026.3000508@hitachi.com \
    --to=masami.hiramatsu.pt@hitachi.com \
    --cc=C.Emde@osadl.org \
    --cc=ak@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=heukelum@fastmail.fm \
    --cc=hpa@zytor.com \
    --cc=jkacur@redhat.com \
    --cc=lgoncalv@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=oleg@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=williams@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.