From: Glauber Costa <glommer@parallels.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: <netdev@vger.kernel.org>, "David S. Miller" <davem@davemloft.net>,
<linux-kernel@vger.kernel.org>
Subject: Re: [v3.3-rc1 regression] TCP: too many of orphaned sockets
Date: Fri, 27 Jan 2012 18:28:41 +0400 [thread overview]
Message-ID: <4F22B499.6080308@parallels.com> (raw)
In-Reply-To: <20120127142246.GA22318@elte.hu>
On 01/27/2012 06:22 PM, Ingo Molnar wrote:
>
> * Ingo Molnar<mingo@elte.hu> wrote:
>
>> ok, i've bisected it, and the bad commit is:
>>
>> 3dc43e3e4d0b52197d3205214fe8f162f9e0c334 is the first bad commit
>> commit 3dc43e3e4d0b52197d3205214fe8f162f9e0c334
>> Author: Glauber Costa<glommer@parallels.com>
>> Date: Sun Dec 11 21:47:05 2011 +0000
>>
>> per-netns ipv4 sysctl_tcp_mem
>
> Might be related to this detail in the .config:
>
> # CONFIG_PROC_SYSCTL is not set
>
> So former tcp_init() code does not get run?
>
> Thanks,
>
> Ingo
Yeah, the problem is that the sysctl variables are used internally
even though CONFIG_PROC_SYSCTL is not set. This patch makes the
initialization happen in the per-netns sysctl initializer, so it will
have bogus values with your config.
Let me send you a test patch shortly.
next prev parent reply other threads:[~2012-01-27 14:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-27 12:46 [v3.3-rc1 regression] TCP: too many of orphaned sockets Ingo Molnar
2012-01-27 12:49 ` Glauber Costa
2012-01-27 12:56 ` Ingo Molnar
2012-01-27 14:17 ` Ingo Molnar
2012-01-27 14:22 ` Ingo Molnar
2012-01-27 14:28 ` Glauber Costa [this message]
2012-01-27 14:35 ` Glauber Costa
2012-01-27 16:27 ` Glauber Costa
2012-01-27 21:28 ` David Miller
2012-01-27 21:28 ` Glauber Costa
2012-01-28 11:50 ` [PATCH] net/tcp: Fix tcp memory limits initialization when !CONFIG_SYSCTL Ingo Molnar
2012-01-30 11:17 ` Glauber Costa
[not found] <inTpE-FS-29@gated-at.bofh.it>
2012-01-30 22:13 ` [v3.3-rc1 regression] TCP: too many of orphaned sockets Arun Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F22B499.6080308@parallels.com \
--to=glommer@parallels.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.