From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Hellstrom Subject: Re: [RFC PATCH] vmwgfx: Fix assignment in vmw_framebuffer_create_handle Date: Fri, 27 Jan 2012 15:54:09 +0100 Message-ID: <4F22BA91.9020406@vmware.com> References: <170320114.179239.1327675287439.JavaMail.root@zimbra-prod-mbox-2.vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <170320114.179239.1327675287439.JavaMail.root@zimbra-prod-mbox-2.vmware.com> Sender: linux-kernel-owner@vger.kernel.org To: Jakob Bornecrantz Cc: airlied@linux.ie, airlied@redhat.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, joe Perches , Ryan Mallon List-Id: dri-devel@lists.freedesktop.org On 01/27/2012 03:41 PM, Jakob Bornecrantz wrote: > ----- Original Message ----- >> On 01/27/2012 03:24 PM, Jakob Bornecrantz wrote: >>> I was asking around and this seems to only be used by X when it >>> starts and we want to preserve the contents of the screen. That >>> feature is implemented by the X driver. So we need to figure how we >>> want to solve it. >>> >>> Either way this fix should probably go into this RC series, not >>> sure if we need to send this to stable, since we are not leaking >>> data to userspace (check drm_mode_getfb), but we might as well. >>> >>> Reviewed-by: Jakob Bornecrantz >> But shouldn't we return the *real* handle. Not 0?? > Yeah, you are right. Not sure we have user_handle in the stable > kernels tho. We do AFAICT. > > We need to change not only the X driver but also all the other > userspace components since at least libkms doesn't create shared > buffers. Libkms is not used anymore, at least not in the X server driver. > And if the thing that is running before X is using fbdev > this wont do much good either since fbdev is not backed by a > fb in the way other drivers do it. OK. Then I suggest we just return 0 here, and go ahead with the current patch, and when we've figured out how to do the handover, we bump kernel minor and return a proper handle. Does that sound OK? /Thomas > > Cheers, Jakob.