From: Daniel De Graaf <dgdegra@tycho.nsa.gov>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH 13/24] mini-os: fix list.h include guard name
Date: Fri, 27 Jan 2012 10:49:44 -0500 [thread overview]
Message-ID: <4F22C798.2080801@tycho.nsa.gov> (raw)
In-Reply-To: <1327669569.26983.178.camel@zakaz.uk.xensource.com>
On 01/27/2012 08:06 AM, Ian Campbell wrote:
> On Thu, 2012-01-26 at 19:45 +0000, Daniel De Graaf wrote:
>> The symbol _LINUX_LIST_H collides with other header files.
>
> Hrm mini-os is supposed to have been BSD licensed since
> 19712:7a215fae6f1f and that symbol name is *rather* suspicious.
>
> The thread associated with that commit[0] suggests that everything GPL
> had been rewritten but I suspect that due to the lack of GPL header this
> file was missed.
>
> This effectively means that any work combined with mini-os was GPL
> rather than BSD as might reasonably have been expected. I believe
> everything in-tree which we link with mini-os (the stubdom/ tree) is GPL
> or GPL-compatible but this has laid rather a nasty trap for anyone else
> using mini-os and I think we should fix it ASAP. Below is a patch which
> switches to using the same BSD sys/queue.h list macros as we use in
> libxl.
I'm assuming you are going to push this patch in prior to my series, so I'll
try to rebase on top of it. Currently, the Makefile changes seem to be broken:
make[3]: *** No rule to make target `/home/daniel/git/xen/tools/libxl/../../tools/include/xen-external/bsd-sys-queue-h-seddery', needed by `_libxl_list.h'. Stop.
>
> Presumably you came across another file which used _LINUX_LIST_H which
> clashed? Out of interest what was it?
>
> Ian.
This symbol is used as the include guard in tools/xenstore/list.h.
next prev parent reply other threads:[~2012-01-27 15:49 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 19:44 [PATCH v5 00/24] Xenstore stub domain Daniel De Graaf
2012-01-26 19:44 ` [PATCH 01/24] xen: reinstate previously unused XENMEM_remove_from_physmap hypercall Daniel De Graaf
2012-01-26 19:44 ` [PATCH 02/24] xen: allow global VIRQ handlers to be delegated to other domains Daniel De Graaf
2012-01-26 19:44 ` [PATCH 03/24] xen: change virq parameters from int to uint32_t Daniel De Graaf
2012-01-26 19:44 ` [PATCH 04/24] xen: use XSM instead of IS_PRIV for getdomaininfo Daniel De Graaf
2012-01-26 19:44 ` [PATCH 05/24] xen: Preserve reserved grant entries when switching versions Daniel De Graaf
2012-01-27 9:54 ` Ian Campbell
2012-01-27 15:12 ` Daniel De Graaf
2012-01-26 19:44 ` [PATCH 06/24] tools/libxl: pull xenstore/console domids from xenstore Daniel De Graaf
2012-01-26 19:44 ` [PATCH 07/24] lib{xc, xl}: Seed grant tables with xenstore and console grants Daniel De Graaf
2012-01-27 10:00 ` Ian Campbell
2012-01-26 19:44 ` [PATCH 08/24] mini-os: avoid crash if no console is provided Daniel De Graaf
2012-01-26 19:44 ` [PATCH 09/24] mini-os: remove per-fd evtchn limit Daniel De Graaf
2012-01-26 19:44 ` [PATCH 10/24] mini-os: create app-specific configuration Daniel De Graaf
2012-01-27 10:04 ` Ian Campbell
2012-01-27 15:26 ` Daniel De Graaf
2012-01-26 19:44 ` [PATCH 11/24] mini-os: Move test functions into test.c Daniel De Graaf
2012-01-27 10:05 ` Ian Campbell
2012-01-26 19:44 ` [PATCH 12/24] mini-os: make frontends and xenbus optional Daniel De Graaf
2012-01-27 10:12 ` Ian Campbell
2012-01-26 19:45 ` [PATCH 13/24] mini-os: fix list.h include guard name Daniel De Graaf
2012-01-27 13:06 ` Ian Campbell
2012-01-27 13:09 ` Ian Campbell
2012-01-27 15:49 ` Daniel De Graaf [this message]
2012-01-27 15:53 ` Ian Campbell
2012-01-28 13:52 ` Keir Fraser
2012-01-31 16:38 ` Ian Jackson
2012-01-26 19:45 ` [PATCH 14/24] xenstored: use grant references instead of map_foreign_range Daniel De Graaf
2012-01-26 19:45 ` [PATCH 15/24] xenstored: refactor socket setup code Daniel De Graaf
2012-01-27 10:17 ` Ian Campbell
2012-01-26 19:45 ` [PATCH 16/24] xenstored: add NO_SOCKETS compilation option Daniel De Graaf
2012-01-27 10:20 ` Ian Campbell
2012-01-26 19:45 ` [PATCH 17/24] xenstored: support for tdb_copy with TDB_INTERNAL Daniel De Graaf
2012-01-26 19:45 ` [PATCH 18/24] xenstored: add --internal-db flag Daniel De Graaf
2012-01-27 10:32 ` Ian Campbell
2012-01-26 19:45 ` [PATCH 19/24] xenstored: support running in minios stubdom Daniel De Graaf
2012-01-27 10:34 ` Ian Campbell
2012-01-27 11:22 ` Stefano Stabellini
2012-01-27 11:49 ` Ian Campbell
2012-01-27 16:11 ` Daniel De Graaf
2012-01-27 16:40 ` Stefano Stabellini
2012-01-26 19:45 ` [PATCH 20/24] stubdom: enable xenstored build Daniel De Graaf
2012-01-27 10:35 ` Ian Campbell
2012-01-26 19:45 ` [PATCH 21/24] xenstored: add --event parameter for bootstrapping Daniel De Graaf
2012-01-26 19:45 ` [PATCH 22/24] xenstored: use domain_is_unprivileged instead of checking conn->id Daniel De Graaf
2012-01-27 10:37 ` Ian Campbell
2012-01-26 19:45 ` [PATCH 23/24] xenstored: add --priv-domid parameter Daniel De Graaf
2012-01-27 10:38 ` Ian Campbell
2012-01-26 19:45 ` [PATCH 24/24] xenstored: Add stub domain builder Daniel De Graaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F22C798.2080801@tycho.nsa.gov \
--to=dgdegra@tycho.nsa.gov \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.