From: Eric Sandeen <sandeen@sandeen.net>
To: Eryu Guan <guaneryu@gmail.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests 273 274 275: do test in dedicated dir and leave test files in it
Date: Fri, 27 Jan 2012 15:16:19 -0600 [thread overview]
Message-ID: <4F231423.8050900@sandeen.net> (raw)
In-Reply-To: <1326388815-21181-1-git-send-email-guaneryu@gmail.com>
On 1/12/12 11:20 AM, Eryu Guan wrote:
> Do all testings in dedicated dir($SCRATCH_MNT/$seq) instead of
> $SCRATCH_MNT and don't remove test files in _cleanup() for debug
> purpose.
>
> Signed-off-by: Eryu Guan <guaneryu@gmail.com>
> ---
...
> @@ -58,8 +60,9 @@ umount $SCRATCH_DEV 2>/dev/null
> _scratch_mkfs_sized $((1 * 1024 * 1024 * 1024)) >>$seq.full 2>&1
> _scratch_mount
>
> -rm -rf $SCRATCH_MNT/*
> -cd $SCRATCH_MNT
> +rm -rf $WORK_DIR
> +mkdir -p $WORK_DIR
Seems like the simplest solution is to just not rm -rf _anything_ immediately
after the mkfs. Why bother? All it does is remove lost+found/ ... wouldn't
it be simpler to just remove that one line?
-Eric
> +cd $WORK_DIR
>
> dd if=/dev/zero of=tmp1 bs=4K count=1 >/dev/null 2>&1
> if [ $? -ne 0 ]
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2012-01-27 21:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 17:20 [PATCH] xfstests 273 274 275: do test in dedicated dir and leave test files in it Eryu Guan
2012-01-27 11:01 ` Christoph Hellwig
2012-01-27 16:28 ` Eryu Guan
2012-01-27 20:42 ` Eric Sandeen
2012-01-27 21:16 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F231423.8050900@sandeen.net \
--to=sandeen@sandeen.net \
--cc=guaneryu@gmail.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.