From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:50464)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanb@linux.vnet.ibm.com>) id 1RqtLD-0001cz-QQ
	for qemu-devel@nongnu.org; Fri, 27 Jan 2012 16:28:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanb@linux.vnet.ibm.com>) id 1RqtLB-0007mN-Iw
	for qemu-devel@nongnu.org; Fri, 27 Jan 2012 16:28:15 -0500
Received: from e2.ny.us.ibm.com ([32.97.182.142]:59936)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanb@linux.vnet.ibm.com>) id 1RqtLB-0007m7-FC
	for qemu-devel@nongnu.org; Fri, 27 Jan 2012 16:28:13 -0500
Received: from /spool/local
	by e2.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
	Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <stefanb@linux.vnet.ibm.com>;
	Fri, 27 Jan 2012 16:28:08 -0500
Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236])
	by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 6F71538C8065
	for <qemu-devel@nongnu.org>; Fri, 27 Jan 2012 16:27:42 -0500 (EST)
Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170])
	by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	q0RLRflv350926
	for <qemu-devel@nongnu.org>; Fri, 27 Jan 2012 16:27:42 -0500
Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1])
	by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP
	id q0RLRfYe027795
	for <qemu-devel@nongnu.org>; Fri, 27 Jan 2012 14:27:41 -0700
Message-ID: <4F2316C9.70807@linux.vnet.ibm.com>
Date: Fri, 27 Jan 2012 16:27:37 -0500
From: Stefan Berger <stefanb@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <4F2312D4.1050408@linux.vnet.ibm.com>
In-Reply-To: <4F2312D4.1050408@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] suspend/resume not working on tip due to 59abb06
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel <qemu-devel@nongnu.org>, blauwirbel@gmail.com

On 01/27/2012 04:10 PM, Stefan Berger wrote:
> After bisecting the following commit seems to be the culprit for the 
> suspend/resume problems that I am seeing with the current tip 
> (73093354418602a2ff5e43cb91a21b17fbf047d8).
>
> commit 59abb06198ee9471e29c970f294eae80c0b39be1
> Author: Blue Swirl <blauwirbel@gmail.com>
> Date:   Sun Jan 22 11:00:44 2012 +0000
>
> Once I revert this patch on the tip everything works fine again...
>
>    Stefan
>
>
And this patch here gets it to work:

diff --git a/exec-obsolete.h b/exec-obsolete.h
index 03cf35e..a673386 100644
--- a/exec-obsolete.h
+++ b/exec-obsolete.h
@@ -101,7 +101,7 @@ static inline void 
cpu_physical_memory_mask_dirty_range(ram_
      end = start + length;
      mask = ~dirty_flags;
      p = ram_list.phys_dirty + (start >> TARGET_PAGE_BITS);
-    for (addr = start; addr <= end; addr += TARGET_PAGE_SIZE) {
+    for (addr = start; addr < end; addr += TARGET_PAGE_SIZE) {
          *p++ &= mask;
      }
  }