From: Timur Tabi <timur@freescale.com>
To: Dmitry Artamonow <mad_soft@inbox.ru>
Cc: <linux-watchdog@vger.kernel.org>,
Kumar Gala <galak@kernel.crashing.org>,
Wim Van Sebroeck <wim@iguana.be>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] watchdog: fix GETTIMEOUT ioctl in booke_wdt
Date: Fri, 27 Jan 2012 15:34:47 -0600 [thread overview]
Message-ID: <4F231877.9050504@freescale.com> (raw)
In-Reply-To: <1327605870-9226-1-git-send-email-mad_soft@inbox.ru>
Dmitry Artamonow wrote:
> Commit dcfb748422 ([WATCHDOG] fix book E watchdog to take
> WDIOC_SETTIMEOUT arg in seconds) fixed SETTIMEOUT ioctl
> to use seconds as a parameter instead of some hardware-specific
> "period", but missed to apply similar changes to GETTIMEOUT,
> so it still returns "period" value. Let's fix it!
> Also, while at it, make SETTIMEOUT ioctl return real timeout
> value as it should do according to the documentation.
>
> Signed-off-by: Dmitry Artamonow <mad_soft@inbox.ru>
> ---
Acked-by: Timur Tabi <timur@freescale.com>
I don't have an easy way to test the watchdog ioctls.
--
Timur Tabi
Linux kernel developer at Freescale
prev parent reply other threads:[~2012-01-27 21:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 19:24 [PATCH] watchdog: fix GETTIMEOUT ioctl in booke_wdt Dmitry Artamonow
2012-01-27 21:08 ` Timur Tabi
2012-01-27 21:22 ` Timur Tabi
2012-01-27 21:34 ` Timur Tabi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F231877.9050504@freescale.com \
--to=timur@freescale.com \
--cc=galak@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=mad_soft@inbox.ru \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.