All of lore.kernel.org
 help / color / mirror / Atom feed
From: Troy Kisky <troy.kisky@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/4] net: phy: add support for Micrel's KSZ9021
Date: Fri, 27 Jan 2012 14:56:52 -0700	[thread overview]
Message-ID: <4F231DA4.7020304@boundarydevices.com> (raw)
In-Reply-To: <201201262154.02374.vapier@gentoo.org>

On 1/26/2012 7:54 PM, Mike Frysinger wrote:
> On Thursday 26 January 2012 17:21:44 Troy Kisky wrote:
>> +/* This is used to set board specific things like clock skew */
>> +unsigned short ksz9021_por_cmds[] = {
> static const

Thanks
>
>> +int ksz9021_send_phy_cmds(struct phy_device *phydev, unsigned short* p)
> static

Thanks
>
>> +	for (;;) {
> personally, i'd prefer:
> 	while (1) {
> -mike
I used to prefer while (1), but then Microsoft started warning about it. 
I doubt GCC ever makes the same decision,
but it is easier to use the same style. And I can't see a downside.

see
http://msdn.microsoft.com/en-us/library/6t66728h%28VS.80%29.aspx

  reply	other threads:[~2012-01-27 21:56 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-26 22:21 [U-Boot] [PATCH 1/4] net: fec_mxc: add 1000 Mbps selection Troy Kisky
2012-01-26 22:21 ` [U-Boot] [PATCH 2/4] net: fec_mxc: add PHYLIB support Troy Kisky
2012-01-30  2:04   ` Andy Fleming
2012-01-31  2:13     ` Troy Kisky
2012-02-01  0:29       ` Andy Fleming
2012-02-01  2:00         ` Troy Kisky
2012-01-26 22:21 ` [U-Boot] [PATCH 3/4] net: phy: add support for Micrel's KSZ9021 Troy Kisky
2012-01-27  2:54   ` Mike Frysinger
2012-01-27 21:56     ` Troy Kisky [this message]
2012-01-30  2:26   ` Andy Fleming
2012-01-30 21:30     ` Troy Kisky
2012-01-31  0:05       ` Andy Fleming
2012-01-31  2:06         ` Troy Kisky
2012-01-26 22:21 ` [U-Boot] [PATCH 4/4] i.mx6q: mx6qsabrelite: Update the network configuration Troy Kisky
2012-01-27 10:25 ` [U-Boot] [PATCH 1/4] net: fec_mxc: add 1000 Mbps selection Dirk Behme
2012-01-30  1:56 ` Andy Fleming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F231DA4.7020304@boundarydevices.com \
    --to=troy.kisky@boundarydevices.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.