Re: [Qemu-devel] git bisect results

[Jan Kiszka <jan.kiszka@web.de>]

[-- Attachment #1: Type: text/plain, Size: 1136 bytes --]

On 2012-01-27 23:52, Jan Kiszka wrote:
> On 2012-01-26 14:10, Erik Rull wrote:
>> I assume from these results that the gui_grab is never set to 1 when having 
>> entered the window in windowed mode with the cursor.
>>
>> Maybe that's why the sdl_grab_start() is called so often.
>>
>> It seems that the condition in sdl_grab_start() (SDL_WM_GrabInput(SDL_GRAB_ON) 
>> == SDL_GRAB_ON) is never fulfilled, otherwise the gui_grab would be set to 1. 
>> But the cursor is actually grabbed in windowed mode, otherwise I would not be 
>> able to click somewhere with the guest-windows-cursor.
> 
> This might be a SDL limitation which does not show up everywhere. Here
> it's fine e.g.
> 
> The logic dates back to "Handle SDL grabs failing (Mark McLoughlin)",
> 6bb816031f. Maybe we can solve that issue without relying on the
> obviously unreliable return value. Need to reproduce that one as well,
> though.

Please check if

git://git.kiszka.org/qemu.git queues/sdl

fixes the issue for you. Namely reverting the above commit should do the
trick. I obsoleted that fragile patch in my series.

Thanks,
Jan



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]