From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:59320)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RrRQJ-0002dY-Oh
	for qemu-devel@nongnu.org; Sun, 29 Jan 2012 04:51:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RrRQI-0008HR-OE
	for qemu-devel@nongnu.org; Sun, 29 Jan 2012 04:51:47 -0500
Received: from cantor2.suse.de ([195.135.220.15]:39880 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RrRQI-0008H9-Jm
	for qemu-devel@nongnu.org; Sun, 29 Jan 2012 04:51:46 -0500
Message-ID: <4F25162E.8080300@suse.de>
Date: Sun, 29 Jan 2012 10:49:34 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1327803571-30553-1-git-send-email-jcmvbkbc@gmail.com>
	<1327803571-30553-5-git-send-email-jcmvbkbc@gmail.com>
In-Reply-To: <1327803571-30553-5-git-send-email-jcmvbkbc@gmail.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [RFC 4/9] exec: add missing breaks to the
	watch_mem_write
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: qemu-devel@nongnu.org

Am 29.01.2012 03:19, schrieb Max Filippov:
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>

Reviewed-by: Andreas F=E4rber <afaerber@suse.de>

Good catch!

Andreas

> ---
>  exec.c |   12 +++++++++---
>  1 files changed, 9 insertions(+), 3 deletions(-)
>=20
> diff --git a/exec.c b/exec.c
> index 5b9eb9a..0e93e0e 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -3279,9 +3279,15 @@ static void watch_mem_write(void *opaque, target=
_phys_addr_t addr,
>  {
>      check_watchpoint(addr & ~TARGET_PAGE_MASK, ~(size - 1), BP_MEM_WRI=
TE);
>      switch (size) {
> -    case 1: stb_phys(addr, val);
> -    case 2: stw_phys(addr, val);
> -    case 4: stl_phys(addr, val);
> +    case 1:
> +        stb_phys(addr, val);
> +        break;
> +    case 2:
> +        stw_phys(addr, val);
> +        break;
> +    case 4:
> +        stl_phys(addr, val);
> +        break;
>      default: abort();
>      }
>  }

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg