From: Suresh Jayaraman <sjayaraman@suse.com>
To: Tejun Heo <tj@kernel.org>
Cc: Vivek Goyal <vgoyal@redhat.com>,
Dirk Gouders <gouders@et.bocholt.fh-gelsenkirchen.de>,
LKML <linux-kernel@vger.kernel.org>, Jens Axboe <axboe@kernel.dk>
Subject: Re: Slab corruption in floppy driver module
Date: Mon, 30 Jan 2012 11:33:51 +0530 [thread overview]
Message-ID: <4F2632C7.2000203@suse.com> (raw)
In-Reply-To: <20120129193601.GD17211@htj.dyndns.org>
On 01/30/2012 01:06 AM, Tejun Heo wrote:
> On Fri, Jan 27, 2012 at 02:54:55PM -0500, Vivek Goyal wrote:
>> floppy: Fix a crash during rmmmod
>>
>> floppy driver does not call add_disk() on all the drives hence we don't take
>> gendisk reference on request queue for these drives. Don't call put_disk()
>> with disk->queue set, otherwise we try to put the reference we never took.
>>
>> Reported-by: Dirk Gouders <gouders@et.bocholt.fh-gelsenkirchen.de>
>> Signed-off-by: Vivek Goyal<vgoyal@redhat.com>
>
> Ugh... floppy init is ugly. Thanks for fixing this.
>
> Acked-by: Tejun Heo <tj@kernel.org>
>
> Jens, this one and the previous one are regression fixes and need to
> be routed through v3.3-fixes.
>
Looks like it needs to be marked for -stable as well as the commit
f992ae8 which exposed these problems was originally marked for -stable?
Suresh
next prev parent reply other threads:[~2012-01-30 6:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-24 13:19 Slab corruption in floppy driver module Suresh Jayaraman
2012-01-24 22:31 ` Vivek Goyal
2012-01-25 7:59 ` Dirk Gouders
2012-01-25 9:04 ` Dirk Gouders
2012-01-26 15:04 ` Vivek Goyal
2012-01-26 18:05 ` Tejun Heo
2012-01-26 18:53 ` Dirk Gouders
2012-01-26 19:37 ` Vivek Goyal
2012-01-26 21:48 ` Dirk Gouders
2012-01-26 21:56 ` Vivek Goyal
2012-01-27 6:07 ` Suresh Jayaraman
2012-01-27 11:30 ` Dirk Gouders
2012-01-27 19:54 ` Vivek Goyal
2012-01-28 10:53 ` Dirk Gouders
2012-01-29 19:36 ` Tejun Heo
2012-01-30 6:03 ` Suresh Jayaraman [this message]
2012-01-27 6:03 ` Suresh Jayaraman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2632C7.2000203@suse.com \
--to=sjayaraman@suse.com \
--cc=axboe@kernel.dk \
--cc=gouders@et.bocholt.fh-gelsenkirchen.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.