From: Raja Mani <rmani@qca.qualcomm.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: <linux-wireless@vger.kernel.org>, <ath6kl-devel@qualcomm.com>
Subject: Re: [PATCH v2 0/8] Allow the user to define suspend mode
Date: Mon, 30 Jan 2012 11:42:18 +0530 [thread overview]
Message-ID: <4F2634C2.2070305@qca.qualcomm.com> (raw)
In-Reply-To: <4F1E9A52.7070202@qca.qualcomm.com>
On Tuesday 24 January 2012 05:17 PM, Kalle Valo wrote:
> Hi Raja,
>
> On 01/20/2012 03:35 PM, rmani@qca.qualcomm.com wrote:
>
>> This series of patch enables the user to specify the suspend mode
>> via module parameter (suspend_mode) while doing insmod of the driver.
>>
>> To select Cut Power mode:
>> insmod ath6kl_sdio.ko suspend_mode = 1
>>
>> To select Deep Sleep mode:
>> insmod ath6kl_sdio.ko suspend_mode = 2
>>
>> To select WOW suspend mode:
>> insmod ath6kl_sdio.ko suspend_mode = 3
>>
>> Existing module param 'suspend_cutpower' variable is renamed to
>> 'suspend_mode' for this purspose.
>>
>> Additionally, If the user doesn't provide any WOW patterns,
>> the default WOW patterns will be configured while going to
>> WOW suspend mode.
>>
>> V2 changes:
>>
>> * Existing automatic suspend mode selection logic is retained.
>> * Suspend mode retry logic is improved without using loop.
>> * Small patches are folded with appropriate patches as per Kalle's comments.
>> * New wmi function is added to process set host sleep mode cmd processed event.
>
> Thanks, this is much better now. I reviewed the patches and found only
> minor issues.
Thanks for your review. I'll take care your comments in V3.
>
> Kalle
prev parent reply other threads:[~2012-01-30 6:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-20 13:35 [PATCH v2 0/8] Allow the user to define suspend mode rmani
2012-01-20 13:35 ` [PATCH v2 1/8] ath6kl: Re-architect suspend mode handling in ath6kl_sdio_suspend rmani
2012-01-24 11:30 ` Kalle Valo
2012-01-20 13:35 ` [PATCH v2 2/8] ath6kl: Add a new func to configure default WOW patterns for AP mode rmani
2012-01-24 11:36 ` Kalle Valo
2012-01-20 13:35 ` [PATCH v2 3/8] ath6kl: Add a new func to config default WOW patterns for non " rmani
2012-01-24 11:39 ` Kalle Valo
2012-01-20 13:35 ` [PATCH v2 4/8] ath6kl: Move WOW patterns config code to a separate function rmani
2012-01-24 11:44 ` Kalle Valo
2012-01-20 13:35 ` [PATCH v2 5/8] ath6kl: Configure WOW patterns while going to wow_suspend rmani
2012-01-20 13:35 ` [PATCH v2 6/8] ath6kl: Return a proper error code when not in connected state rmani
2012-01-24 11:45 ` Kalle Valo
2012-01-20 13:35 ` [PATCH v2 7/8] ath6kl: Add a support to handle the host sleep mode cmd processed event rmani
2012-01-24 11:46 ` Kalle Valo
2012-01-20 13:35 ` [PATCH v2 8/8] ath6kl: Wait for host sleep mode cmd processed event during WOW suspend rmani
2012-01-24 11:47 ` [PATCH v2 0/8] Allow the user to define suspend mode Kalle Valo
2012-01-30 6:12 ` Raja Mani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2634C2.2070305@qca.qualcomm.com \
--to=rmani@qca.qualcomm.com \
--cc=ath6kl-devel@qualcomm.com \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.