Re: [RFC][PATCH] tracing/module: Move tracepoint out of module.h

[Li Zefan <lizf@cn.fujitsu.com>]

Steven Rostedt wrote:
> On Thu, 2012-01-26 at 09:04 -0500, Steven Rostedt wrote:
>> [ Added Li who added the original tracepoint ]
>>
>> On Thu, 2012-01-26 at 14:55 +0100, Ingo Molnar wrote:
>>> * Steven Rostedt <rostedt@goodmis.org> wrote:
>>>
>>>> On Thu, 2012-01-26 at 11:28 +0100, Ingo Molnar wrote:
>>>>
>>>>> How much more do we save if we move all of try_module_get() out 
>>>>> of line? It still seems a rather thick inline function with 
>>>>> preempt section and all. I'd *really* suggest that it should all 
>>>>> be uninlined.
>>>>>
>>>>
>>>> Here's the #'s
>>>>
>>>>    text	   data	    bss	    dec	    hex	filename
>>>> 7489488	2249584	9719808	19458880	128eb40	vmlinux-prepatch
>>>>    text	   data	    bss	    dec	    hex	filename
>>>> 7482458	2248048	9719808	19450314	128c9ca	vmlinux-postpatch
>>>>    text	   data	    bss	    dec	    hex	filename
>>>> 7477393	2248080	9719808	19445281	128b621	vmlinux-updatedpatch
> 
> 
> New numbers:
> 
>    text	   data	    bss	    dec	    hex	filename
> 7476509	2248048	9719808	19444365	128b28d	vmlinux-updatedpatch2
> 
> Just 916 bytes savings more. But gets rid of the hot path changes.
> 
> New patch below: (and the IP still works)
> 
> -- Steve
> 

This looks good to me. Thanks!

--
Li Zefan