All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Sixt <j.sixt@viscovery.net>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: Felipe Contreras <felipe.contreras@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] completion: add new zsh completion
Date: Mon, 30 Jan 2012 12:11:05 +0100	[thread overview]
Message-ID: <4F267AC9.1080407@viscovery.net> (raw)
In-Reply-To: <vpqwr89d1p7.fsf@bauges.imag.fr>

Am 1/30/2012 9:39, schrieb Matthieu Moy:
> Felipe Contreras <felipe.contreras@gmail.com> writes:
> 
>> +ZSH_VERSION='' . /usr/share/git/completion/git-completion.bash
> 
> Probably stating the obvious, but this path shouldn't be hardcoded.
> 
> Something along the lines of
> 
> ZSH_VERSION='' . $(dirname ${funcsourcetrace[1]%:*})/git-completion.bash
> 
> should do it (mostly untested, and written by a non-ZSH expert).

Moreover, if zsh is POSIX compliant, the value of ZSH_VERSION will be an
empty string after this statement. That may or (more likely) may not be
what you want.

-- Hannes

  parent reply	other threads:[~2012-01-30 11:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-30  0:01 [PATCH] completion: add new zsh completion Felipe Contreras
2012-01-30  8:39 ` Matthieu Moy
2012-01-30 10:59   ` Felipe Contreras
2012-01-30 11:28     ` Felipe Contreras
2012-01-30 11:11   ` Johannes Sixt [this message]
2012-01-30 11:32     ` Felipe Contreras
2012-01-30 18:52     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F267AC9.1080407@viscovery.net \
    --to=j.sixt@viscovery.net \
    --cc=Matthieu.Moy@grenoble-inp.fr \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.