Re: [PATCH] irq_domain/microblaze: Convert microblaze to use irq_domains

[Michal Simek <monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org>]

Hi Grant,

Grant Likely wrote:
> ***totally untested.  Don't apply yet***
> 
> Michal, I leave it to you to test this patch.  I've turned on SPARSE_IRQ, but
> you may decide that isn't valuable.  I've compile tested it, but that's
> about it (in fact, I had to hack head.S to get it to build because I don't have
> an up-to-date compiler for microblaze.  It fails on an unknown opcode 'lwr')
> 

I have looked at it and I there is problem with virq allocation in irq_create_mapping
which calles irq_alloc_desc(0) and then __irq_alloc_descs(-1, 0, 1, node, THIS_MODULE)
where bitmap_find_next_zero_area returns 0 (start = 0) which is passed to alloc_descs
which just return it.
It doesn't matter if SPARSE_IRQ is enabled or not.
Error log is below.

Can you give me hint how to fix it and what expected values are?

Thanks,
Michal

Error log:

NR_IRQS:64
XPS intc #0 at 0xc8000000, num_irq=6, edge=0x0
irq: Allocated domain of type 2 @0xc7802760
irq: irq_create_mapping(0xc7802760, 0x2)
irq: -> using domain @c7802760
irq: -> virq allocation failed
XPS timer #0 at 0xc8002000, irq=0



-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian