From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Sachin Kamat <sachin.kamat@linaro.org>,
linux-media@vger.kernel.org, mchehab@infradead.org,
kyungmin.park@samsung.com, k.debski@samsung.com,
patches@linaro.org
Subject: Re: [PATCH][media] s5p-g2d: Add HFLIP and VFLIP support
Date: Mon, 30 Jan 2012 14:04:56 +0100 [thread overview]
Message-ID: <4F269578.5040205@samsung.com> (raw)
In-Reply-To: <201201301311.48370.laurent.pinchart@ideasonboard.com>
On 01/30/2012 01:11 PM, Laurent Pinchart wrote:
>> static int g2d_open(struct file *file)
>> @@ -564,6 +591,8 @@ static void device_run(void *prv)
>> g2d_set_dst_addr(dev, vb2_dma_contig_plane_dma_addr(dst, 0));
>>
>> g2d_set_rop4(dev, ctx->rop);
>> + g2d_set_flip(dev, ctx->hflip | ctx->vflip);
>> +
>
> Is this called for every frame, or once at stream start only ? In the later
> case, this means that hflip and vflip won't be changeable during streaming. Is
> that on purpose ?
The device_run() callback is called per each frame, i.e. per each single
buffer pair. Hence it should be possible to reconfigure flipping when
streaming is on.
Thanks,
--
Sylwester Nawrocki
Samsung Poland R&D Center
next prev parent reply other threads:[~2012-01-30 13:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 9:58 [PATCH][media] s5p-g2d: Add HFLIP and VFLIP support Sachin Kamat
2012-01-30 12:11 ` Laurent Pinchart
2012-01-30 13:04 ` Sylwester Nawrocki [this message]
2012-01-30 13:39 ` Kamil Debski
2012-01-31 5:07 ` Sachin Kamat
2012-01-31 9:30 ` Laurent Pinchart
2012-01-31 10:09 ` Kamil Debski
2012-01-31 12:42 ` Sachin Kamat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F269578.5040205@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=k.debski@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=patches@linaro.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.