* [PATCH net-next] ipv6: fix RFC5722 comment
@ 2012-01-30 14:29 Eric Dumazet
2012-01-30 14:42 ` Nicolas Dichtel
2012-01-30 17:59 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Eric Dumazet @ 2012-01-30 14:29 UTC (permalink / raw)
To: David Miller; +Cc: netdev, Nicolas Dichtel
RFC5722 Section 4 was amended by Errata 3089
Our implementation did the right thing anyway...
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Nicolas Dichtel <nicolas.dichtel@6wind.com>
---
net/ipv6/reassembly.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/net/ipv6/reassembly.c b/net/ipv6/reassembly.c
index b69fae7..9447bd6 100644
--- a/net/ipv6/reassembly.c
+++ b/net/ipv6/reassembly.c
@@ -336,12 +336,11 @@ static int ip6_frag_queue(struct frag_queue *fq, struct sk_buff *skb,
}
found:
- /* RFC5722, Section 4:
- * When reassembling an IPv6 datagram, if
+ /* RFC5722, Section 4, amended by Errata ID : 3089
+ * When reassembling an IPv6 datagram, if
* one or more its constituent fragments is determined to be an
* overlapping fragment, the entire datagram (and any constituent
- * fragments, including those not yet received) MUST be silently
- * discarded.
+ * fragments) MUST be silently discarded.
*/
/* Check for overlap with preceding fragment. */
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] ipv6: fix RFC5722 comment
2012-01-30 14:29 [PATCH net-next] ipv6: fix RFC5722 comment Eric Dumazet
@ 2012-01-30 14:42 ` Nicolas Dichtel
2012-01-30 17:59 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Dichtel @ 2012-01-30 14:42 UTC (permalink / raw)
To: Eric Dumazet; +Cc: David Miller, netdev
Le 30/01/2012 15:29, Eric Dumazet a écrit :
> RFC5722 Section 4 was amended by Errata 3089
>
> Our implementation did the right thing anyway...
>
> Signed-off-by: Eric Dumazet<eric.dumazet@gmail.com>
> Cc: Nicolas Dichtel<nicolas.dichtel@6wind.com>
Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> ---
> net/ipv6/reassembly.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/net/ipv6/reassembly.c b/net/ipv6/reassembly.c
> index b69fae7..9447bd6 100644
> --- a/net/ipv6/reassembly.c
> +++ b/net/ipv6/reassembly.c
> @@ -336,12 +336,11 @@ static int ip6_frag_queue(struct frag_queue *fq, struct sk_buff *skb,
> }
>
> found:
> - /* RFC5722, Section 4:
> - * When reassembling an IPv6 datagram, if
> + /* RFC5722, Section 4, amended by Errata ID : 3089
> + * When reassembling an IPv6 datagram, if
Identation was an exact copy of the original rfc (not changed by the errata),
but it's a detail ;-)
Regards,
Nicolas
> * one or more its constituent fragments is determined to be an
> * overlapping fragment, the entire datagram (and any constituent
> - * fragments, including those not yet received) MUST be silently
> - * discarded.
> + * fragments) MUST be silently discarded.
> */
>
> /* Check for overlap with preceding fragment. */
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] ipv6: fix RFC5722 comment
2012-01-30 14:29 [PATCH net-next] ipv6: fix RFC5722 comment Eric Dumazet
2012-01-30 14:42 ` Nicolas Dichtel
@ 2012-01-30 17:59 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2012-01-30 17:59 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev, nicolas.dichtel
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 30 Jan 2012 15:29:24 +0100
> RFC5722 Section 4 was amended by Errata 3089
>
> Our implementation did the right thing anyway...
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> Cc: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Applied, thanks Eric.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-30 17:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-30 14:29 [PATCH net-next] ipv6: fix RFC5722 comment Eric Dumazet
2012-01-30 14:42 ` Nicolas Dichtel
2012-01-30 17:59 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.