From: Paolo Bonzini <pbonzini@redhat.com>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org, "Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH] m48t59: use rtc_clock for alarm timer
Date: Mon, 30 Jan 2012 17:40:21 +0100 [thread overview]
Message-ID: <4F26C7F5.9070802@redhat.com> (raw)
In-Reply-To: <1327061100-9286-1-git-send-email-pbonzini@redhat.com>
On 01/20/2012 01:05 PM, Paolo Bonzini wrote:
> This lets the RTC get adjustments from the host NTP client.
> The watchdog still uses the vm_clock. The previous behavior is
> available with "-rtc clock=vm".
>
> Cc: Andreas Färber<afaerber@suse.de>
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
> ---
> hw/m48t59.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/m48t59.c b/hw/m48t59.c
> index c043996..fd5dc00 100644
> --- a/hw/m48t59.c
> +++ b/hw/m48t59.c
> @@ -126,7 +126,7 @@ static void alarm_cb (void *opaque)
> /* Repeat once a second */
> next_time = 1;
> }
> - qemu_mod_timer(NVRAM->alrm_timer, qemu_get_clock_ns(vm_clock) +
> + qemu_mod_timer(NVRAM->alrm_timer, qemu_get_clock_ns(rtc_clock) +
> next_time * 1000);
> qemu_set_irq(NVRAM->IRQ, 0);
> }
> @@ -687,7 +687,7 @@ static void m48t59_init_common(M48t59State *s)
> {
> s->buffer = g_malloc0(s->size);
> if (s->type == 59) {
> - s->alrm_timer = qemu_new_timer_ns(vm_clock,&alarm_cb, s);
> + s->alrm_timer = qemu_new_timer_ns(rtc_clock,&alarm_cb, s);
> s->wd_timer = qemu_new_timer_ns(vm_clock,&watchdog_cb, s);
> }
> qemu_get_timedate(&s->alarm, 0);
Ping.
Paolo
next prev parent reply other threads:[~2012-01-30 16:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-20 12:05 [Qemu-devel] [PATCH] m48t59: use rtc_clock for alarm timer Paolo Bonzini
2012-01-20 12:45 ` Andreas Färber
2012-01-30 16:40 ` Paolo Bonzini [this message]
2012-01-30 19:29 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F26C7F5.9070802@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.