All of lore.kernel.org
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Cc: Koen Kooi <koen@dominion.thruhere.net>
Subject: Re: [PATCH 1/2] alsa-state: fix RDEPENDS assignment
Date: Mon, 30 Jan 2012 12:09:57 -0800	[thread overview]
Message-ID: <4F26F915.3040307@linux.intel.com> (raw)
In-Reply-To: <6432C232-C013-4AB3-AED2-0ED908B5C30C@dominion.thruhere.net>

On 01/30/2012 10:39 AM, Koen Kooi wrote:
> Op 30 jan. 2012, om 18:50 heeft Joshua Lock het volgende geschreven:
>
>> Yikes, I don't know why I keep making this mistake. Thanks for catching it Koen.
>
> I'm still finding recipes that I wrote that have that mistake :)
>
>> I thought we caught this in a QA error but I definitely didn't see it, best investigate.
>
> it's part of recipe-sanity, which you need to call manually.
>

Time to add that to my checklist!  I have a set of things I am trying to 
remember to do (they don't always get done, but I try) to validate recipes.

Sau!

> regards,
>
> Koen
>
>
>>
>> On 30/01/12 08:49, Koen Kooi wrote:
>>> Signed-off-by: Koen Kooi<koen@dominion.thruhere.net>
>> Signed-off-by: Joshua Lock<josh@linux.intel.com>
>>
>> Joshua
>>
>>> ---
>>>   meta/recipes-bsp/alsa-state/alsa-state.bb |    5 ++---
>>>   1 files changed, 2 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/meta/recipes-bsp/alsa-state/alsa-state.bb b/meta/recipes-bsp/alsa-state/alsa-state.bb
>>> index bc17b25..83c9faa 100644
>>> --- a/meta/recipes-bsp/alsa-state/alsa-state.bb
>>> +++ b/meta/recipes-bsp/alsa-state/alsa-state.bb
>>> @@ -10,7 +10,7 @@ sound state at system boot and save it at system shut down."
>>>   LICENSE = "MIT"
>>>   LIC_FILES_CHKSUM = "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
>>>   PV = "0.2.0"
>>> -PR = "r0"
>>> +PR = "r2"
>>>
>>>   SRC_URI = "\
>>>     file://asound.conf \
>>> @@ -18,8 +18,6 @@ SRC_URI = "\
>>>     file://alsa-state \
>>>   "
>>>
>>> -RDEPENDS = "alsa-utils-alsactl"
>>> -
>>>   inherit update-rc.d
>>>
>>>   INITSCRIPT_NAME = "alsa-state"
>>> @@ -39,6 +37,7 @@ PACKAGES += "alsa-states"
>>>
>>>   RRECOMMENDS_alsa-state = "alsa-states"
>>>
>>> +RDEPENDS_${PN} = "alsa-utils-alsactl"
>>>   FILES_${PN} = "${sysconfdir}/init.d ${sysconfdir}/asound.conf"
>>>   CONFFILES_${PN} = "${sysconfdir}/asound.conf"
>>>
>>
>> --
>> Joshua Lock
>>         Yocto Project "Johannes factotum"
>>         Intel Open Source Technology Centre
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>



  reply	other threads:[~2012-01-30 20:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-30 16:49 [PATCH 1/2] alsa-state: fix RDEPENDS assignment Koen Kooi
2012-01-30 16:49 ` [PATCH 2/2] alsa-utils: make alsa-utils-alsactl recommend alsa-states Koen Kooi
2012-01-30 17:51   ` Joshua Lock
2012-01-30 17:50 ` [PATCH 1/2] alsa-state: fix RDEPENDS assignment Joshua Lock
2012-01-30 17:56   ` Phil Blundell
2012-01-30 18:17     ` Joshua Lock
2012-01-30 18:39   ` Koen Kooi
2012-01-30 20:09     ` Saul Wold [this message]
2012-02-02 17:57 ` Saul Wold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F26F915.3040307@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=koen@dominion.thruhere.net \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.