[Cluster-devel] [PATCH] fence_rhevm: Incorrect status detected when VM is not in up/down

[Lon Hohberger <lhh@redhat.com>]

On 01/30/2012 10:58 AM, Marek 'marx' Grac wrote:
> For fencing purposes we have to focus on getting OFF status
> when machine is really 100% down, conditions for ON status are much simplier
> (as fact that machine is has power does not mean that it works). This patch
> specify condition for OFF status - in fact only 'Down' is accepted now
>
> Resolves: rhbz#769681
> ---
>   fence/agents/rhevm/fence_rhevm.py |    6 +++---
>   1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fence/agents/rhevm/fence_rhevm.py b/fence/agents/rhevm/fence_rhevm.py
> index 65a7395..3578b5f 100644
> --- a/fence/agents/rhevm/fence_rhevm.py
> +++ b/fence/agents/rhevm/fence_rhevm.py
> @@ -41,10 +41,10 @@ def get_power_status(conn, options):
>   	else:
>   		status = result.group(1)
>
> -	if (status == "up"):
> -		return "on"
> -	else:
> +	if (status.lower() == "down"):
>   		return "off"
> +	else:
> +		return "on"
>
>   def set_power_status(conn, options):
>   	action = {


This looks correct based on the bugzilla.

-- Lon