From: Johannes Berg <johannes@sipsolutions.net>
To: Victor Goldenshtein <victorg@ti.com>
Cc: linux-wireless@vger.kernel.org, kgiori@qca.qualcomm.com,
mcgrof@frijolero.org, zefir.kurtisi@neratec.com,
adrian.chadd@gmail.com, j@w1.fi, coelho@ti.com, assaf@ti.com,
yoni.divinsky@ti.com, igalc@ti.com, adrian@freebsd.org,
nbd@nbd.name
Subject: Re: [RFC 1/9] nl80211/cfg80211: add radar detection command/event
Date: Mon, 30 Jan 2012 21:39:25 -0800 [thread overview]
Message-ID: <4F277E8D.5040809@sipsolutions.net> (raw)
In-Reply-To: <1327581484-22047-2-git-send-email-victorg@ti.com>
On 1/26/2012 4:37 AM, Victor Goldenshtein wrote:
> + * @NL80211_CMD_DFS_RADAR_DETECTION: Start radar detection in the
> + * driver/HW. Once radar detected usermode notified with this event.
Why DFS & radar detection? I mean, why not just call it CMD_RADAR_DETECT
or so?
> + *
> + * @dfs_start_radar_detection: Start radar detection in the driver.
ditto here
> @@ -3216,6 +3221,17 @@ void cfg80211_cqm_rssi_notify(struct net_device *dev,
> gfp_t gfp);
>
> /**
> + * cfg80211_radar_detected_notify - radar detection event
The _notify suffix seems useless, maybe remove it?
> + * @dev: network device
> + * @freq: radar detected on this channel frequency
unit?
> +static int nl80211_dfs_start_radar_detection(struct sk_buff *skb,
> + struct genl_info *info)
> +{
> + struct cfg80211_registered_device *rdev = info->user_ptr[0];
> + struct net_device *dev = info->user_ptr[1];
> +
> + ASSERT_RDEV_LOCK(rdev);
That assert isn't really worth much here.
How do you *end* radar detection? What channel does it apply to? Any
channel you're on? The channel you were on when it was enabled?
johannes
next prev parent reply other threads:[~2012-01-31 5:40 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 12:37 [RFC 0/9] nl/cfg/mac80211: add DFS master ability Victor Goldenshtein
2012-01-26 12:37 ` [RFC 1/9] nl80211/cfg80211: add radar detection command/event Victor Goldenshtein
2012-01-31 5:39 ` Johannes Berg [this message]
2012-02-02 16:06 ` Goldenshtein, Victor
2012-02-09 22:02 ` Luis R. Rodriguez
2012-02-15 16:45 ` Goldenshtein, Victor
2012-01-26 12:37 ` [RFC 2/9] mac80211: " Victor Goldenshtein
2012-01-31 5:42 ` Johannes Berg
2012-02-02 16:06 ` Goldenshtein, Victor
2012-01-26 12:37 ` [RFC 3/9] nl80211/cfg80211: add ability to enable TX on op-channel Victor Goldenshtein
2012-01-31 5:43 ` Johannes Berg
2012-02-02 16:06 ` Goldenshtein, Victor
[not found] ` <4F2B18AA.90809@neratec.com>
2012-02-06 11:16 ` zefir.kurtisi
2012-02-06 13:01 ` Goldenshtein, Victor
2012-02-06 14:48 ` Zefir Kurtisi
2012-02-06 15:34 ` Goldenshtein, Victor
2012-02-06 21:01 ` Johannes Berg
2012-02-09 21:04 ` Goldenshtein, Victor
2012-02-09 22:34 ` Luis R. Rodriguez
2012-02-15 16:45 ` Goldenshtein, Victor
2012-03-15 9:37 ` Goldenshtein, Victor
2012-03-15 21:04 ` Coelho, Luciano
2012-01-26 12:37 ` [RFC 4/9] mac80211: " Victor Goldenshtein
2012-01-31 5:45 ` Johannes Berg
2012-02-02 16:06 ` Goldenshtein, Victor
2012-02-09 22:36 ` Luis R. Rodriguez
2012-02-15 16:45 ` Goldenshtein, Victor
2012-01-26 12:38 ` [RFC 5/9] nl80211/cfg80211: add ap channel switch command/event Victor Goldenshtein
2012-01-31 5:46 ` Johannes Berg
2012-02-02 16:07 ` Goldenshtein, Victor
2012-02-09 22:53 ` Luis R. Rodriguez
2012-02-15 16:46 ` Goldenshtein, Victor
2012-01-26 12:38 ` [RFC 6/9] mac80211: " Victor Goldenshtein
2012-01-31 5:51 ` Johannes Berg
2012-02-02 16:07 ` Goldenshtein, Victor
2012-02-06 21:03 ` Johannes Berg
2012-02-09 20:02 ` Goldenshtein, Victor
2012-02-09 23:04 ` Luis R. Rodriguez
2012-02-15 16:46 ` Goldenshtein, Victor
2012-02-09 23:06 ` Luis R. Rodriguez
2012-02-15 16:46 ` Goldenshtein, Victor
2012-01-26 12:38 ` [RFC 7/9] nl80211/cfg80211: add DFS feature flag Victor Goldenshtein
2012-01-31 5:52 ` Johannes Berg
2012-02-02 16:08 ` Goldenshtein, Victor
2012-02-09 23:11 ` Luis R. Rodriguez
2012-02-13 10:28 ` Johannes Berg
2012-02-15 17:01 ` Goldenshtein, Victor
2012-02-15 16:46 ` Goldenshtein, Victor
2012-01-26 12:38 ` [RFC 8/9] mac80211: add DFS capabilities flag Victor Goldenshtein
2012-01-31 5:52 ` Johannes Berg
2012-02-02 16:08 ` Goldenshtein, Victor
2012-01-26 12:38 ` [RFC 9/9] mac80211: add DFS support to monitor interface Victor Goldenshtein
2012-01-26 14:10 ` Christian Lamparter
2012-01-26 15:50 ` Goldenshtein, Victor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F277E8D.5040809@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=adrian.chadd@gmail.com \
--cc=adrian@freebsd.org \
--cc=assaf@ti.com \
--cc=coelho@ti.com \
--cc=igalc@ti.com \
--cc=j@w1.fi \
--cc=kgiori@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@frijolero.org \
--cc=nbd@nbd.name \
--cc=victorg@ti.com \
--cc=yoni.divinsky@ti.com \
--cc=zefir.kurtisi@neratec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.