From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takuya Yoshikawa Subject: Re: [PATCH 4/4 v3] KVM: Introduce kvm_memory_slot::arch and move lpage_info into it Date: Tue, 31 Jan 2012 18:32:32 +0900 Message-ID: <4F27B530.70707@oss.ntt.co.jp> References: <20120130124859.6c3bb19f.yoshikawa.takuya@oss.ntt.co.jp> <20120130125308.51e22f12.yoshikawa.takuya@oss.ntt.co.jp> <20120130143533.e52efcbe.yoshikawa.takuya@oss.ntt.co.jp> <4F274144.9000606@oss.ntt.co.jp> <4F27B1F8.9040500@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: mtosatti@redhat.com, kvm@vger.kernel.org, Alexander Graf , cotte@de.ibm.com, Paul Mackerras , borntraeger@de.ibm.com To: Avi Kivity Return-path: Received: from serv2.oss.ntt.co.jp ([222.151.198.100]:49393 "EHLO serv2.oss.ntt.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752132Ab2AaJal (ORCPT ); Tue, 31 Jan 2012 04:30:41 -0500 In-Reply-To: <4F27B1F8.9040500@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: (2012/01/31 18:18), Avi Kivity wrote: > On 01/31/2012 03:17 AM, Takuya Yoshikawa wrote: >> Added s390 and ppc developers to Cc, >> >> (2012/01/30 14:35), Takuya Yoshikawa wrote: >>> Some members of kvm_memory_slot are not used by every architecture. >>> >>> This patch is the first step to make this difference clear by >>> introducing kvm_memory_slot::arch; lpage_info is moved into it. >> >> I am planning to move rmap stuff into arch next if this patch is >> accepted. >> >> Please let me know if you have some opinion about which members should be >> moved into this. >> > > Is there anything else? Everything else seems to be generic. > About members, I agree. But dirty_bitmap allocation/destruction should be implemented by kvm_arch_create_*_dirty_bitmap(). Of course I may want to add another x86 specific member in the future. Takuya