From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:56400) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RsB75-0003C3-N3 for qemu-devel@nongnu.org; Tue, 31 Jan 2012 05:39:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RsB74-0003Qr-FD for qemu-devel@nongnu.org; Tue, 31 Jan 2012 05:38:59 -0500 Received: from cantor2.suse.de ([195.135.220.15]:33346 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RsB74-0003Qm-89 for qemu-devel@nongnu.org; Tue, 31 Jan 2012 05:38:58 -0500 Message-ID: <4F27C437.1020305@suse.de> Date: Tue, 31 Jan 2012 11:36:39 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1327843531-32403-1-git-send-email-afaerber@suse.de> <1327843531-32403-5-git-send-email-afaerber@suse.de> <4F25FCF3.2000702@codemonkey.ws> In-Reply-To: <4F25FCF3.2000702@codemonkey.ws> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH RFC 4/7] qom: Introduce CPU class List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org Am 30.01.2012 03:14, schrieb Anthony Liguori: > On 01/29/2012 07:25 AM, Andreas F=C3=A4rber wrote: >> +static TypeInfo cpu_type_info =3D { >> + .name =3D TYPE_CPU, >> + .parent =3D TYPE_OBJECT, >> + .instance_size =3D sizeof(CPU), >=20 >=20 > Probably want to do CPUState or something of that nature so that you ca= n > use CPU() as a dynamic_cast macro. My testing seems to indicate CPU and CPU(obj) can co-exist (GCC 4.6.2). Considered name alternatives: CPUState - already taken as #define for legacy CPU${arch}State CPUCore - fits ARM but there's socket vs. core vs. thread on x86 CPUCommon - puts the emphasis on common, which is not a noun CommonCPU - no other base class uses such a naming scheme CPUModel - it's not just a model but the state of one instance CPUFamily - same as for CPUModel CPUState would be nicest IMO, but refactoring CPUState into something else just to refactor it back to QOM CPUState feels like churn. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg