Re: [PATCH 2/2] mmc: sdhci-s3c: support the broken voltage.

[Jaehoon Chung <jh80.chung@samsung.com>]

On 01/31/2012 07:32 PM, Girish K S wrote:

> On 31 January 2012 12:25, Jaehoon Chung <jh80.chung@samsung.com> wrote:
>> Samsung-SoC need to add the MMC_CAP2_BROKEN_VOLTAGE.
>>
>>
>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>>  drivers/mmc/host/sdhci-s3c.c |    7 +++----
>>  1 files changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
>> index d065e37..e7e2b6b 100644
>> --- a/drivers/mmc/host/sdhci-s3c.c
>> +++ b/drivers/mmc/host/sdhci-s3c.c
>> @@ -521,9 +521,12 @@ static int __devinit sdhci_s3c_probe(struct platform_device *pdev)
>>        if (pdata->cd_type == S3C_SDHCI_CD_PERMANENT)
>>                host->mmc->caps = MMC_CAP_NONREMOVABLE;
>>
>> +       /* It supports additional host capabilities if needed */
>>        if (pdata->host_caps)
>>                host->mmc->caps |= pdata->host_caps;
>>
>> +       host->mmc->caps2 = MMC_CAP2_BROKEN_VOLTAGE;
> 
> Dont you think this should be set in the machine specific platform
> data structure. If done in the machine specific file
> only   if (pdata->host_caps2)
>               host->mmc->caps2 |= pdata->host_caps2
> would be more generic to pull all the caps2 fields

Right..i think also that.
Actually I sent the second capability patch for Samsung-SoC before...
Kukjin Kim didn't accept the patch.
http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg07456.html
http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg07455.html

I will resend the patch..if he will accept them..

Best Regards,
Jaehoon Chung

> 
>> +
>>        if (pdata->pm_caps)
>>                host->mmc->pm_caps |= pdata->pm_caps;
>>
>> @@ -543,10 +546,6 @@ static int __devinit sdhci_s3c_probe(struct platform_device *pdev)
>>                sdhci_s3c_ops.get_max_clock = sdhci_cmu_get_max_clock;
>>        }
>>
>> -       /* It supports additional host capabilities if needed */
>> -       if (pdata->host_caps)
>> -               host->mmc->caps |= pdata->host_caps;
>> -
>>        ret = sdhci_add_host(host);
>>        if (ret) {
>>                dev_err(dev, "sdhci_add_host() failed\n");
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>