From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Tue, 31 Jan 2012 12:25:08 +0100 Subject: [U-Boot] SPL Linux Boot In-Reply-To: References: <1313073896-12952-1-git-send-email-simonschwarzcor@gmail.com> <1324049833-18143-1-git-send-email-sbabic@denx.de> <4EEEF940.8090709@denx.de> <4F1FEC7F.9030405@denx.de> <4F20283D.9020007@denx.de> <4F23FF4D.5040204@denx.de> Message-ID: <4F27CF94.4050603@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 30/01/2012 19:05, Tom Rini wrote: Hi Tom, >> OK, doing a MAKEALL for omap3/4/5/am33xx/davinci shows we've got a few >> missing include problems, I'll go fix that up. > > OK, was it when you took over the series that you moved stuff to > common/spl.c ? That idea is breaking, badly, non-omap platforms. I am trying to summarize the different problems we have. Comparing to u-boot-ti, the patchset breaks the following boards: davinci: da850_am18xxevm da850evm hawkboard_nand omap4/5: fixed including spl.h into arch/arm/cpu/armv7/omap-common/boot-common.c mx28: m28evk mx28evk I have not seen other broken boards - let me know if you find something else. On omap4/5 is only a thing of include files, as you reported. A main issue is with davinci, because we have currently two different spl.c (arch/arm/cpu/arm926ejs/davinci/spl.c on davinci). The code can be factorized, if davinci will use preloader_console_init() as omap. The same problem rises with mx28: there is a specific file arch/arm/cpu/arm926ejs/mx28/spl_boot.c, that redefines board_init_f() and board_init_r() - as we try to have a common spl code, this muist be fixed, too. A way can be to add an arch weak function to add arch specific initialization inside board_init_*() functions, if any. Have you seen other issues other what I report now ? Stefano -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================